Bug 231574

Summary: Expose MediaCapabilities to Workers
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, clopez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/31261
Bug Depends on: 231568    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2021-10-12 07:28:27 PDT 
Expose MediaCapabilities to Workers
Comment 1 youenn fablet 2021-10-12 07:49:09 PDT 
Created attachment 440932 [details]
Patch
Comment 2 youenn fablet 2021-10-15 00:02:15 PDT 
Created attachment 441340 [details]
Patch
Comment 3 EWS Watchlist 2021-10-15 00:03:15 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 youenn fablet 2021-10-15 00:27:33 PDT 
Created attachment 441341 [details]
Patch
Comment 5 youenn fablet 2021-10-15 00:28:24 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/31261
Comment 6 youenn fablet 2021-10-15 06:09:44 PDT 
Created attachment 441369 [details]
Patch
Comment 7 youenn fablet 2021-10-15 06:36:16 PDT 
Created attachment 441370 [details]
Patch
Comment 8 youenn fablet 2021-10-18 05:10:36 PDT 
Created attachment 441587 [details]
Patch
Comment 9 Eric Carlson 2021-10-18 09:17:03 PDT 
Comment on attachment 441587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441587&action=review

> Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:-197
> -#if !RELEASE_LOG_DISABLED
> -        logger->info(LogMedia, identifier, " - Rejected. configuration: ", configuration);
> -#endif

Why not log the error?
Comment 10 youenn fablet 2021-10-19 01:04:17 PDT 
Created attachment 441698 [details]
Patch for landing
Comment 11 youenn fablet 2021-10-19 01:05:02 PDT 
(In reply to Eric Carlson from comment #9)
> Comment on attachment 441587 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441587&action=review
> 
> > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:-197
> > -#if !RELEASE_LOG_DISABLED
> > -        logger->info(LogMedia, identifier, " - Rejected. configuration: ", configuration);
> > -#endif
> 
> Why not log the error?

I added it back
Comment 12 EWS 2021-10-19 04:05:26 PDT 
Committed r284443 (243205@main): <https://commits.webkit.org/243205@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441698 [details].
Comment 13 Radar WebKit Bug Importer 2021-10-19 04:06:19 PDT 
<rdar://problem/84409518>