Bug 231571

Summary: Eliminate duplicated platform-specific code in ScrollingTreeStickyNode
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: ScrollingAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, ews-watchlist, fred.wang, gyuyoung.kim, jamesr, luiz, ryuan.choi, sergio, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2021-10-12 05:48:10 PDT
Both the Nicosia and Cocoa ports duplicate code specific to making sticky nodes work in the scrolling tree. Instead, this code could be moved to a shared class.
Attachments
Patch (64.62 KB, patch)
2021-10-13 04:45 PDT, Martin Robinson
no flags
Patch (65.27 KB, patch)
2021-10-13 06:03 PDT, Martin Robinson
no flags
Patch (65.44 KB, patch)
2021-10-13 12:03 PDT, Martin Robinson
no flags
Patch (65.47 KB, patch)
2021-10-27 03:33 PDT, Martin Robinson
no flags
Simon Fraser (smfr)
Comment 1 2021-10-12 09:38:19 PDT
Overflow and frame scrolling nodes also share a bit of code.
Martin Robinson
Comment 2 2021-10-13 04:45:46 PDT
Martin Robinson
Comment 3 2021-10-13 06:03:23 PDT
Martin Robinson
Comment 4 2021-10-13 12:03:23 PDT
Radar WebKit Bug Importer
Comment 5 2021-10-19 05:49:19 PDT
Martin Robinson
Comment 6 2021-10-27 03:33:36 PDT
EWS
Comment 7 2021-10-27 04:47:36 PDT
Committed r284920 (243591@main): <https://commits.webkit.org/243591@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442576 [details].
Note You need to log in before you can comment on or make changes to this bug.