| Summary: | MediaCapabilities should enqueue a task to resolve promises | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 231568 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2021-10-12 05:19:56 PDT
Created attachment 440918 [details]
Patch
Comment on attachment 440918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440918&action=review > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215 > logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); It looks like this indentation is wrong now > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269 > + logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); Ditto Created attachment 441201 [details]
Patch for landing
(In reply to Eric Carlson from comment #2) > Comment on attachment 440918 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440918&action=review > > > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215 > > logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); > > It looks like this indentation is wrong now > > > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269 > > + logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); > > Ditto Fixed in landing patch Committed r284236 (243045@main): <https://commits.webkit.org/243045@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441201 [details]. |