Bug 231569

Summary: MediaCapabilities should enqueue a task to resolve promises
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231568    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2021-10-12 05:19:56 PDT
MediaCapabilities should enqueue a task to resolve promises
Attachments
Patch (10.46 KB, patch)
2021-10-12 05:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.55 KB, patch)
2021-10-14 04:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-10-12 05:21:43 PDT
Created attachment 440918 [details] Patch
Eric Carlson
Comment 2 2021-10-13 08:53:35 PDT
Comment on attachment 440918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440918&action=review > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215 > logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); It looks like this indentation is wrong now > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269 > + logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); Ditto
youenn fablet
Comment 3 2021-10-14 04:04:05 PDT
Created attachment 441201 [details] Patch for landing
youenn fablet
Comment 4 2021-10-14 04:04:20 PDT
(In reply to Eric Carlson from comment #2) > Comment on attachment 440918 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440918&action=review > > > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:215 > > logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); > > It looks like this indentation is wrong now > > > Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:269 > > + logger->info(LogMedia, identifier, "::callback() - Resolved. info: ", info); > > Ditto Fixed in landing patch
EWS
Comment 5 2021-10-14 23:33:11 PDT
Committed r284236 (243045@main): <https://commits.webkit.org/243045@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441201 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-14 23:34:17 PDT
<rdar://problem/84290404>
Note You need to log in before you can comment on or make changes to this bug.