Bug 231527

Summary: [build-imagediff] Build universal binaries by default
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, ryanhaddad, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2021-10-11 13:18:53 PDT
ImageDiff is a small enough program that we should really just always builds it with both x86 and arm64 on Mac.
Attachments
Patch (1.02 KB, patch)
2021-10-11 13:20 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-11 13:19:26 PDT
<rdar://problem/84113091>
Jonathan Bedard
Comment 2 2021-10-11 13:20:21 PDT
Created attachment 440829 [details] Patch
Ryan Haddad
Comment 3 2021-10-11 14:07:13 PDT
Comment on attachment 440829 [details] Patch Seems reasonable to me.
Jonathan Bedard
Comment 4 2021-10-11 14:37:18 PDT
Some context, we know we need this for our arm Simulator bots: https://build.webkit.org/#/builders/298/builds/2
EWS
Comment 5 2021-10-11 15:20:03 PDT
Committed r283939 (242798@main): <https://commits.webkit.org/242798@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440829 [details].
Note You need to log in before you can comment on or make changes to this bug.