Bug 231527

Summary:

[build-imagediff] Build universal binaries by default

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dewei_zhu, ryanhaddad, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2021-10-11 13:18:53 PDT

ImageDiff is a small enough program that we should really just always builds it with both x86 and arm64 on Mac.

Comment 1 Radar WebKit Bug Importer 2021-10-11 13:19:26 PDT

<rdar://problem/84113091>

Comment 2 Jonathan Bedard 2021-10-11 13:20:21 PDT

Created attachment 440829 [details]
Patch

Comment 3 Ryan Haddad 2021-10-11 14:07:13 PDT

Comment on attachment 440829 [details]
Patch

Seems reasonable to me.

Comment 4 Jonathan Bedard 2021-10-11 14:37:18 PDT

Some context, we know we need this for our arm Simulator bots:
https://build.webkit.org/#/builders/298/builds/2

Comment 5 EWS 2021-10-11 15:20:03 PDT

Committed r283939 (242798@main): <https://commits.webkit.org/242798@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440829 [details].