Bug 231500

Summary: Beef up worker termination handling in ReadableStream routines
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2021-10-11 01:22:15 PDT
Beef up worker termination handling in ReadableStream routines
Attachments
Patch (4.16 KB, patch)
2021-10-11 01:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-10-11 01:23:13 PDT
<rdar://83687915>
youenn fablet
Comment 2 2021-10-11 01:24:05 PDT
I am not quite sure whether we need to check for termination after wrapping of an existing C++ object into a JS object. @Mark, any suggestion here?
youenn fablet
Comment 3 2021-10-11 01:26:31 PDT
Created attachment 440763 [details] Patch
Darin Adler
Comment 4 2021-10-25 14:50:01 PDT
Comment on attachment 440763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review > Source/WebCore/ChangeLog:10 > + Covered by existing tests. How can that be true? Why do we need to "beef up" if nothing is changing?
youenn fablet
Comment 5 2021-10-26 02:11:37 PDT
Comment on attachment 440763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review >> Source/WebCore/ChangeLog:10 >> + Covered by existing tests. > > How can that be true? Why do we need to "beef up" if nothing is changing? We are adding more checks so code is changing. I think it is covered by existing tests that are currently crashing on debug asserts, like https://bugs.webkit.org/show_bug.cgi?id=230984.
EWS
Comment 6 2021-10-26 02:46:36 PDT
Committed r284861 (243538@main): <https://commits.webkit.org/243538@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440763 [details].
Note You need to log in before you can comment on or make changes to this bug.