| Summary: | Beef up worker termination handling in ReadableStream routines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, mark.lam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2021-10-11 01:22:15 PDT
I am not quite sure whether we need to check for termination after wrapping of an existing C++ object into a JS object. @Mark, any suggestion here? Created attachment 440763 [details]
Patch
Comment on attachment 440763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review > Source/WebCore/ChangeLog:10 > + Covered by existing tests. How can that be true? Why do we need to "beef up" if nothing is changing? Comment on attachment 440763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440763&action=review >> Source/WebCore/ChangeLog:10 >> + Covered by existing tests. > > How can that be true? Why do we need to "beef up" if nothing is changing? We are adding more checks so code is changing. I think it is covered by existing tests that are currently crashing on debug asserts, like https://bugs.webkit.org/show_bug.cgi?id=230984. Committed r284861 (243538@main): <https://commits.webkit.org/243538@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440763 [details]. |