Bug 231478

Summary:

AX: AccessibilityMenuListPopup shouldn't add ignored children

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tyler Wilcock 2021-10-09 09:03:16 PDT

An invariant of our accessibility tree is that it doesn't include things that are ignored. Most paths end up at AccessibilityObject::insertChild, which prevents ignored children from being inserted. However, AccessibilityMenuListPopup::addChildren directly calls m_children.append, so it should ensure the things it adds aren't ignored first.

Comment 1 Radar WebKit Bug Importer 2021-10-09 09:03:30 PDT

<rdar://problem/84062657>

Comment 2 Tyler Wilcock 2021-10-09 09:09:02 PDT

Created attachment 440711 [details]
Patch

Comment 3 chris fleizach 2021-10-09 09:24:00 PDT

Comment on attachment 440711 [details]
Patch

Is it possible to add an example of an ignored menu list item in a layout test?

Comment 4 Tyler Wilcock 2021-10-09 11:51:44 PDT

(In reply to chris fleizach from comment #3)
> Comment on attachment 440711 [details]
> Patch
> 
> Is it possible to add an example of an ignored menu list item in a layout
> test?

We can't test this because AccessibilityMenuListPopup is ignored on Mac and iOS, so its addChildren method never gets called, and thus we can't exercise the changed code. This patch would make this class do the right thing should it become un-ignored.

Comment 5 chris fleizach 2021-10-09 13:14:16 PDT

Which platforms will this have an effect on?

Comment 6 Andres Gonzalez 2021-10-12 07:09:07 PDT

(In reply to Tyler Wilcock from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 440711 [details]
> > Patch
> > 
> > Is it possible to add an example of an ignored menu list item in a layout
> > test?
> 
> We can't test this because AccessibilityMenuListPopup is ignored on Mac and
> iOS, so its addChildren method never gets called, and thus we can't exercise
> the changed code. This patch would make this class do the right thing should
> it become un-ignored.

How can AccessibilityMenuListPopup become un-ignored?