Bug 231469
| Summary: | REGRESSION (r283824): Monterey tests are running on Big Sur | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, jenner, simon.fraser, tsavell, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
I am on Big Sur, but run-webkit-tests is running tests in fast/images/text-recognition which are marked as Skip, but enabled for Monterey:
[ Monterey+ ] fast/images/text-recognition [ Pass ]
Bots are also seeing this: https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r440671-14054/results.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
Some debugging shows that run-webkit-tests things my OS is "monterey" despite being 11.3. This is coming from:
CURRENT_VERSION = Version(12, 0)
in class MacPort(DarwinPort). In that __init__ function, we seem to be hitting the default clause:
if not self._os_version:
self._os_version = MacPort.CURRENT_VERSION
host.platform.os_version is correct.
When running open source tests, apple_additions() is None.
Simon Fraser (smfr)
Fixed in https://trac.webkit.org/changeset/283850/webkit.
Radar WebKit Bug Importer
<rdar://problem/84053307>