Bug 231441

Summary: Ensure that animated scrolls will run on the scrolling thread
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cathiechen, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, mrobinson, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+, ews-feeder: commit-queue-

Description Simon Fraser (smfr) 2021-10-08 11:33:13 PDT
Ensure that animated scrolls will run on the scrolling thread
Comment 1 Simon Fraser (smfr) 2021-10-08 11:37:56 PDT
Created attachment 440650 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-08 13:00:18 PDT
Created attachment 440660 [details]
Patch
Comment 3 Tim Horton 2021-10-08 14:00:58 PDT
Comment on attachment 440660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440660&action=review

> Source/WebCore/ChangeLog:8
> +        On macOS, scrolling tree commits run the main thread (holding a lock), so we can't start

missing an "on" I think

> Source/WebCore/ChangeLog:12
> +        to bounce to the scrolling tree to start animations. We also have intercept requested scroll

"we have intercept"
Comment 4 Simon Fraser (smfr) 2021-10-08 16:16:37 PDT
https://trac.webkit.org/changeset/283849/webkit
Comment 5 Radar WebKit Bug Importer 2021-10-08 16:20:11 PDT
<rdar://problem/84048278>