Bug 23144
| Summary: | ScopeChain::push/pop look suspiciously unsafe | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | zwarich |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Oliver Hunt
Title says it all -- m_node is refed on construct, and deref'd in the destructor,m but push/pop don't appear to propagate this ref
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Oliver Hunt
scopechainnode is now gc allocated so no manual ref/deref