Bug 231428

Summary: Merge optimizations to AudioParamTimeline::hasValues() from Blink
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/web-platform-tests/wpt/pull/31165
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-10-08 07:29:06 PDT
Merge optimizations to AudioParamTimeline::hasValues() from Blink.
Attachments
WIP Patch (16.58 KB, patch)
2021-10-08 07:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.68 KB, patch)
2021-10-08 07:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.68 KB, patch)
2021-10-08 08:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.68 KB, patch)
2021-10-08 08:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-10-08 07:29:38 PDT
Created attachment 440606 [details] WIP Patch
EWS Watchlist
Comment 2 2021-10-08 07:30:40 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Chris Dumez
Comment 3 2021-10-08 07:59:16 PDT
Created attachment 440613 [details] Patch
Chris Dumez
Comment 4 2021-10-08 08:27:00 PDT
Created attachment 440617 [details] Patch
Eric Carlson
Comment 5 2021-10-08 08:46:22 PDT
Comment on attachment 440617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440617&action=review r=me once the bots are happy > Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:1014 > + // The first event starts after the end of this rendering quantum so no automation is needed. This should be after the `if (...` or should be reworded, e.g. "If the first event starts ..."
Chris Dumez
Comment 6 2021-10-08 08:50:41 PDT
Created attachment 440621 [details] Patch
EWS
Comment 7 2021-10-08 12:29:59 PDT
Committed r283825 (242712@main): <https://commits.webkit.org/242712@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440621 [details].
Radar WebKit Bug Importer
Comment 8 2021-10-08 12:30:19 PDT
<rdar://problem/84038739>
Note You need to log in before you can comment on or make changes to this bug.