| Summary: | Merge optimizations to AudioParamTimeline::hasValues() from Blink | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| URL: | https://github.com/web-platform-tests/wpt/pull/31165 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2021-10-08 07:29:06 PDT
Created attachment 440606 [details]
WIP Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 440613 [details]
Patch
Created attachment 440617 [details]
Patch
Comment on attachment 440617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440617&action=review r=me once the bots are happy > Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:1014 > + // The first event starts after the end of this rendering quantum so no automation is needed. This should be after the `if (...` or should be reworded, e.g. "If the first event starts ..." Created attachment 440621 [details]
Patch
Committed r283825 (242712@main): <https://commits.webkit.org/242712@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440621 [details]. |