Bug 231420

Summary: [GTK][WPE] Remove the support to build with internal jhbuild
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: aakash_jain, bugs-noreply, clopez, ews-watchlist, glenn, jbedard, pnormand
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213614
https://bugs.webkit.org/show_bug.cgi?id=237107
Attachments:
Description Flags
Patch clopez: review-, pnormand: commit-queue-

Description Carlos Garcia Campos 2021-10-08 04:06:19 PDT
We are now using flatpak in the bots and the jhbuild modulesets are outdated and not maintained anymore.
Comment 1 Carlos Garcia Campos 2021-10-08 04:10:50 PDT
Created attachment 440591 [details]
Patch

Jonathan, this patch will require to restart the bots too.
Comment 2 Carlos Garcia Campos 2021-10-08 04:14:19 PDT
Red EWS for GTK and WPE are expected, since the patch is changing the bots config.
Comment 3 Philippe Normand 2021-10-08 05:11:57 PDT
Comment on attachment 440591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440591&action=review

> Tools/Scripts/clean-webkit:-68
> -            keepDirs = usesFlatpak() and ["Toolchains", "UserFlatpak"] or ["DependenciesGTK", "DependenciesWPE"]

Toolchains is in UserFlatpak now, so this can be simplified a bit.
Comment 4 Carlos Alberto Lopez Perez 2021-10-08 05:16:09 PDT
Please don't.

We still use JHBuild on the packaging bots that create the bundles for using on the WPT CI

Example: https://build.webkit.org/#/builders/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004

They use the "minimal" version of JHBuild (see bug 213614 )

I have plans to move those bots to create a bundle based on Flatpak instead, but I have still work ahead to reach that point.

So for now please keep the JHBuild.
Comment 5 Carlos Garcia Campos 2021-10-08 05:19:21 PDT
Sure, I didn't know we were still using jhbuild. So, we are building with old dependencies then for WPT CI.