Bug 231420

Summary:

[GTK][WPE] Remove the support to build with internal jhbuild

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

aakash_jain, bugs-noreply, clopez, ews-watchlist, glenn, jbedard, pnormand

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=213614
https://bugs.webkit.org/show_bug.cgi?id=237107

Attachments:

Description	Flags
Patch	clopez: review-, pnormand: commit-queue-

Carlos Garcia Campos

Reported 2021-10-08 04:06:19 PDT

We are now using flatpak in the bots and the jhbuild modulesets are outdated and not maintained anymore.

Attachments
Patch (218.69 KB, patch) 2021-10-08 04:10 PDT, Carlos Garcia Campos	clopez: review- pnormand: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2021-10-08 04:10:50 PDT

Created attachment 440591 [details] Patch Jonathan, this patch will require to restart the bots too.

Carlos Garcia Campos

Comment 2 2021-10-08 04:14:19 PDT

Red EWS for GTK and WPE are expected, since the patch is changing the bots config.

Philippe Normand

Comment 3 2021-10-08 05:11:57 PDT

Comment on attachment 440591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440591&action=review > Tools/Scripts/clean-webkit:-68 > - keepDirs = usesFlatpak() and ["Toolchains", "UserFlatpak"] or ["DependenciesGTK", "DependenciesWPE"] Toolchains is in UserFlatpak now, so this can be simplified a bit.

Carlos Alberto Lopez Perez

Comment 4 2021-10-08 05:16:09 PDT

Please don't. We still use JHBuild on the packaging bots that create the bundles for using on the WPT CI Example: https://build.webkit.org/#/builders/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 They use the "minimal" version of JHBuild (see bug 213614 ) I have plans to move those bots to create a bundle based on Flatpak instead, but I have still work ahead to reach that point. So for now please keep the JHBuild.

Carlos Garcia Campos

Comment 5 2021-10-08 05:19:21 PDT

Sure, I didn't know we were still using jhbuild. So, we are building with old dependencies then for WPT CI.

Note You need to log in before you can comment on or make changes to this bug.