Bug 231417

Summary:

Refactor shouldAutofocus to only call trivial Document getters

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

NEW ---

Severity:

Normal

CC:

cdumez, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, mifenton, ntim, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review-

Description youenn fablet 2021-10-08 03:48:26 PDT

Refactor shouldAutofocus to only call trivial Document getters

Comment 1 youenn fablet 2021-10-08 04:07:40 PDT

Created attachment 440590 [details]
Patch

Comment 2 Ryosuke Niwa 2021-10-09 01:23:18 PDT

Comment on attachment 440590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440590&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:210
>      auto& document = element.document();

We really need to store this in Ref. r- because of this.

Comment 3 Radar WebKit Bug Importer 2021-10-15 03:49:16 PDT

<rdar://problem/84296162>