Bug 231384

Summary: AX: Expose the URL attribute of <video> elements
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, eric.carlson, ews-watchlist, glenn, jcraig, jdiggs, jer.noble, philipj, samuel_white, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2021-10-07 12:24:29 PDT
Expose the URL attribute of <video> elements.
Attachments
Patch (167.73 KB, patch)
2021-10-07 12:30 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (169.38 KB, patch)
2021-10-07 15:10 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-07 12:24:40 PDT
<rdar://problem/83993905>
Tyler Wilcock
Comment 2 2021-10-07 12:30:10 PDT
Created attachment 440523 [details] Patch
chris fleizach
Comment 3 2021-10-07 13:52:53 PDT
Comment on attachment 440523 [details] Patch wk1 test failure
Tyler Wilcock
Comment 4 2021-10-07 15:10:18 PDT
Created attachment 440543 [details] Patch
Tyler Wilcock
Comment 5 2021-10-07 15:12:29 PDT
Fixed the WK1 failure and skipping the test on Windows. I didn't realize tests in accessibility/ are skipped by default on iOS, so I'm going to try enabling the new test and running in EWS to see if I can get it passing. (I'd test locally, but having trouble getting the iOS simulator built.)
Andres Gonzalez
Comment 6 2021-10-08 06:36:02 PDT
(In reply to Tyler Wilcock from comment #4) > Created attachment 440543 [details] > Patch looks great.
EWS
Comment 7 2021-10-08 07:34:38 PDT
Committed r283799 (242692@main): <https://commits.webkit.org/242692@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440543 [details].
Note You need to log in before you can comment on or make changes to this bug.