Bug 231384 - AX: Expose the URL attribute of <video> elements
Summary: AX: Expose the URL attribute of <video> elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-07 12:24 PDT by Tyler Wilcock
Modified: 2021-10-08 07:34 PDT (History)
15 users (show)

See Also:

Attachments
Patch (167.73 KB, patch)
2021-10-07 12:30 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (169.38 KB, patch)
2021-10-07 15:10 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-10-07 12:24:29 PDT 
Expose the URL attribute of <video> elements.
Comment 1 Radar WebKit Bug Importer 2021-10-07 12:24:40 PDT 
<rdar://problem/83993905>
Comment 2 Tyler Wilcock 2021-10-07 12:30:10 PDT 
Created attachment 440523 [details]
Patch
Comment 3 chris fleizach 2021-10-07 13:52:53 PDT 
Comment on attachment 440523 [details]
Patch

wk1 test failure
Comment 4 Tyler Wilcock 2021-10-07 15:10:18 PDT 
Created attachment 440543 [details]
Patch
Comment 5 Tyler Wilcock 2021-10-07 15:12:29 PDT 
Fixed the WK1 failure and skipping the test on Windows. I didn't realize tests in accessibility/ are skipped by default on iOS, so I'm going to try enabling the new test and running in EWS to see if I can get it passing.

(I'd test locally, but having trouble getting the iOS simulator built.)
Comment 6 Andres Gonzalez 2021-10-08 06:36:02 PDT 
(In reply to Tyler Wilcock from comment #4)
> Created attachment 440543 [details]
> Patch

looks great.
Comment 7 EWS 2021-10-08 07:34:38 PDT 
Committed r283799 (242692@main): <https://commits.webkit.org/242692@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440543 [details].