Bug 231370

Summary: Do not check for firstLineStyle while constructing RenderText
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2021-10-07 10:16:19 PDT
first line style computation expects the renderer to be fully attached to the tree.
Attachments
Patch (8.32 KB, patch)
2021-10-07 10:32 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.35 KB, patch)
2021-10-07 15:01 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-10-07 10:29:19 PDT
<rdar://83973189>
zalan
Comment 2 2021-10-07 10:32:46 PDT
Created attachment 440511 [details] Patch
Antti Koivisto
Comment 3 2021-10-07 10:35:42 PDT
Comment on attachment 440511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440511&action=review > Source/WebCore/rendering/RenderText.cpp:1432 > // FIXME: All these checks should be more fine-grained at the inline item level. I guess this FIXME is still relevant?
zalan
Comment 4 2021-10-07 10:36:47 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 440511 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440511&action=review > > > Source/WebCore/rendering/RenderText.cpp:1432 > > // FIXME: All these checks should be more fine-grained at the inline item level. > > I guess this FIXME is still relevant? yeah for the rest of the content it still is.
zalan
Comment 5 2021-10-07 15:01:59 PDT
Created attachment 440541 [details] Patch
EWS
Comment 6 2021-10-07 16:25:13 PDT
Committed r283754 (242675@main): <https://commits.webkit.org/242675@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440541 [details].
Myles C. Maxfield
Comment 7 2021-10-07 16:31:05 PDT
Committed r283755 (242676@main): <https://commits.webkit.org/242676@main>
Myles C. Maxfield
Comment 8 2021-10-07 16:32:29 PDT
(In reply to Myles C. Maxfield from comment #7) > Committed r283755 (242676@main): <https://commits.webkit.org/242676@main> What? So confused.
Myles C. Maxfield
Comment 9 2021-10-07 16:33:49 PDT
To anyone following along: `webkit-patch` messed up, and accidentally thought my patch was this one. The comment above in https://bugs.webkit.org/show_bug.cgi?id=231370#c7 is bogus, please ignore.
Note You need to log in before you can comment on or make changes to this bug.