Summary: | Do not check for firstLineStyle while constructing RenderText | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2021-10-07 10:16:19 PDT
Created attachment 440511 [details]
Patch
Comment on attachment 440511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440511&action=review > Source/WebCore/rendering/RenderText.cpp:1432 > // FIXME: All these checks should be more fine-grained at the inline item level. I guess this FIXME is still relevant? (In reply to Antti Koivisto from comment #3) > Comment on attachment 440511 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440511&action=review > > > Source/WebCore/rendering/RenderText.cpp:1432 > > // FIXME: All these checks should be more fine-grained at the inline item level. > > I guess this FIXME is still relevant? yeah for the rest of the content it still is. Created attachment 440541 [details]
Patch
Committed r283754 (242675@main): <https://commits.webkit.org/242675@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440541 [details]. Committed r283755 (242676@main): <https://commits.webkit.org/242676@main> (In reply to Myles C. Maxfield from comment #7) > Committed r283755 (242676@main): <https://commits.webkit.org/242676@main> What? So confused. To anyone following along: `webkit-patch` messed up, and accidentally thought my patch was this one. The comment above in https://bugs.webkit.org/show_bug.cgi?id=231370#c7 is bogus, please ignore. |