Bug 231363

Summary: [LFC][Integration] Use optimized InlineContent::boxesForRect for hit testing
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antti Koivisto
Reported 2021-10-07 09:17:21 PDT
faster hit testing
Attachments
Patch (4.63 KB, patch)
2021-10-07 09:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-10-07 09:23:35 PDT
Created attachment 440504 [details] Patch
EWS
Comment 2 2021-10-07 11:32:56 PDT
Committed r283726 (242650@main): <https://commits.webkit.org/242650@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440504 [details].
Radar WebKit Bug Importer
Comment 3 2021-10-07 11:33:18 PDT
<rdar://problem/83991388>
Darin Adler
Comment 4 2021-10-07 11:38:23 PDT
Is IteratorRange itself not reversible? Can we make it reversible?
Antti Koivisto
Comment 5 2021-10-07 12:15:25 PDT
(In reply to Darin Adler from comment #4) > Is IteratorRange itself not reversible? Can we make it reversible? It is not and it would be nice if it was. Reversibility depends on the iterator capabilities so a generic reversible version is probably slightly trickier.
Darin Adler
Comment 6 2021-10-07 12:31:53 PDT
(In reply to Antti Koivisto from comment #5) > It is not and it would be nice if it was. Reversibility depends on the > iterator capabilities so a generic reversible version is probably slightly > trickier. One idea is to specialize it so it’s reversible when the iterators are pointers. Over time could use better template meta programming to make it reversible in even more cases.
Antti Koivisto
Comment 7 2021-10-08 03:22:15 PDT
Turns out it wasn't difficult at all, bug 231415.
Note You need to log in before you can comment on or make changes to this bug.