Bug 231356

Summary: [LFC][Integration] Optimize InlineContent::boxesForRect
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Antti Koivisto 2021-10-07 06:00:47 PDT 
Approximate the box range from average line height.
Comment 1 Antti Koivisto 2021-10-07 06:20:51 PDT 
Created attachment 440497 [details]
Patch
Comment 2 zalan 2021-10-07 07:15:21 PDT 
Comment on attachment 440497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440497&action=review

> Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h:64
> +    bool hasMultilineInkOverflow { false };

this could also be triggered by just normal (non-ink)overlap with line-height other than normal.
Comment 3 Antti Koivisto 2021-10-07 07:27:06 PDT 
Created attachment 440501 [details]
Patch
Comment 4 EWS 2021-10-07 08:02:04 PDT 
Committed r283711 (242637@main): <https://commits.webkit.org/242637@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440501 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-07 08:03:32 PDT 
<rdar://problem/83981134>