Bug 231356 - [LFC][Integration] Optimize InlineContent::boxesForRect
Summary: [LFC][Integration] Optimize InlineContent::boxesForRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-07 06:00 PDT by Antti Koivisto
Modified: 2021-10-07 08:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2021-10-07 06:20 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (5.29 KB, patch)
2021-10-07 07:27 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-10-07 06:00:47 PDT 
Approximate the box range from average line height.
Comment 1 Antti Koivisto 2021-10-07 06:20:51 PDT 
Created attachment 440497 [details]
Patch
Comment 2 zalan 2021-10-07 07:15:21 PDT 
Comment on attachment 440497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440497&action=review

> Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h:64
> +    bool hasMultilineInkOverflow { false };

this could also be triggered by just normal (non-ink)overlap with line-height other than normal.
Comment 3 Antti Koivisto 2021-10-07 07:27:06 PDT 
Created attachment 440501 [details]
Patch
Comment 4 EWS 2021-10-07 08:02:04 PDT 
Committed r283711 (242637@main): <https://commits.webkit.org/242637@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440501 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-07 08:03:32 PDT 
<rdar://problem/83981134>