Bug 23134

Summary:

Safari 3.2.1 used by bisect-builds tool crashes during testing builds earlier than r37348

Product:

WebKit

Reporter:

Robert Blaut <webkit>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
crash log	none
fix for the crash bug	eric: review+

Robert Blaut

Reported 2009-01-06 06:28:32 PST

The crash bug is visible with Safari 3.2.1 installed and with build older than r37348. So I assume changeset <http://trac.webkit.org/changeset/37348> is problematic. Crash log attached.

Attachments
crash log (25.79 KB, text/plain) 2009-01-06 06:28 PST, Robert Blaut	no flags	Details
fix for the crash bug (1.82 KB, patch) 2009-01-06 14:26 PST, Robert Blaut	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Robert Blaut

Comment 1 2009-01-06 06:28:53 PST

Created attachment 26459 [details] crash log

Alexey Proskuryakov

Comment 2 2009-01-06 11:52:37 PST

Sounds like a WONTFIX to me - certainly we can't preserve compatibility forever?

Robert Blaut

Comment 3 2009-01-06 14:25:34 PST

(In reply to comment #2) > Sounds like a WONTFIX to me - certainly we can't preserve compatibility > forever? > So we should prevent bisect-builds from running incompatible builds :)

Robert Blaut

Comment 4 2009-01-06 14:26:18 PST

Created attachment 26475 [details] fix for the crash bug

Eric Seidel (no email)

Comment 5 2009-01-06 15:36:42 PST

Comment on attachment 26475 [details] fix for the crash bug Looks fine. Seems like we should be using some sub routines for this sort of thing, instead of copy paste.

Alexey Proskuryakov

Comment 6 2009-01-11 01:43:29 PST

Committed revision 39788.

Note You need to log in before you can comment on or make changes to this bug.