Bug 23134

Summary:

Safari 3.2.1 used by bisect-builds tool crashes during testing builds earlier than r37348

Product:

WebKit

Reporter:

Robert Blaut <webkit>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
crash log	none
fix for the crash bug	eric: review+

Description Robert Blaut 2009-01-06 06:28:32 PST

The crash bug is visible with Safari 3.2.1 installed and with build older than r37348. 

So I assume changeset <http://trac.webkit.org/changeset/37348> is problematic.

Crash log attached.

Comment 1 Robert Blaut 2009-01-06 06:28:53 PST

Created attachment 26459 [details]
crash log

Comment 2 Alexey Proskuryakov 2009-01-06 11:52:37 PST

Sounds like a WONTFIX to me - certainly we can't preserve compatibility forever?

Comment 3 Robert Blaut 2009-01-06 14:25:34 PST

(In reply to comment #2)
> Sounds like a WONTFIX to me - certainly we can't preserve compatibility
> forever?
> 

So we should prevent bisect-builds from running incompatible builds :)

Comment 4 Robert Blaut 2009-01-06 14:26:18 PST

Created attachment 26475 [details]
fix for the crash bug

Comment 5 Eric Seidel (no email) 2009-01-06 15:36:42 PST

Comment on attachment 26475 [details]
fix for the crash bug

Looks fine.  Seems like we should be using some sub routines for this sort of thing, instead of copy paste.

Comment 6 Alexey Proskuryakov 2009-01-11 01:43:29 PST

Committed revision 39788.