| Summary: | [JSC] Temporal tweaks to pass more test262 tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philip Chimento <philip.chimento> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, xan.lopez, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Philip Chimento
2021-10-06 14:24:05 PDT
Created attachment 440438 [details]
Patch
Created attachment 440443 [details]
Patch
Comment on attachment 440443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440443&action=review Quick comment > Source/JavaScriptCore/runtime/TemporalObject.h:67 > +// https://tc39.es/proposal-temporal/#table-temporal-temporaldurationlike-properties > +static constexpr TemporalUnit temporalUnitsInTableOrder[numberOfTemporalUnits] = { > + TemporalUnit::Day, > + TemporalUnit::Hour, > + TemporalUnit::Microsecond, > + TemporalUnit::Millisecond, > + TemporalUnit::Minute, > + TemporalUnit::Month, > + TemporalUnit::Nanosecond, > + TemporalUnit::Second, > + TemporalUnit::Week, > + TemporalUnit::Year, > +}; Let's put the array content to cpp file to avoid materializing the same constant array multiple times. This will enlarge binary size. Created attachment 440451 [details]
Patch
Comment on attachment 440451 [details]
Patch
r=me
Committed r283705 (242631@main): <https://commits.webkit.org/242631@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440451 [details]. |