Bug 231290

Summary:

Removing <dialog> from document should reset m_isModal flag

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

DOM

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84635

Attachments:

Description	Flags
Patch	zalan: review+

Description Tim Nguyen (:ntim) 2021-10-06 07:42:38 PDT

m_isModal triggers the :-internal-modal-dialog pseudo class, which changes position from absolute to fixed.

When removing a modal <dialog> from the document, it is also removed from the top layer, it makes sense to reset the modal dialog flag as well as a result.

Comment 1 Tim Nguyen (:ntim) 2021-10-06 07:49:59 PDT

Created attachment 440366 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2021-10-06 08:29:34 PDT

<rdar://problem/83934967>

Comment 3 Tim Nguyen (:ntim) 2021-10-06 10:29:52 PDT

Committed r283631 (242582@main): <https://commits.webkit.org/242582@main>