Summary: | Add DRT API to retrieve number of active animations from AnimationController | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pierre-Olivier Latour <pol> | ||||
Component: | Tools / Tests | Assignee: | Pierre-Olivier Latour <pol> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarrin, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 22239 | ||||||
Attachments: |
|
Description
Pierre-Olivier Latour
2009-01-05 16:47:18 PST
Created attachment 26481 [details]
Patch v1
Comment on attachment 26481 [details] Patch v1 > + RefPtr<CompositeAnimation> compAnim = it->second; > + count += compAnim->numberOfActiveAnimations(); This will unnecessarily churn the reference count of the animation. You should either use a raw pointer for the local variable, or just use it->second directly. r=me (including Darin's recommended change) Sending LayoutTests/ChangeLog Adding LayoutTests/animations/animation-controller-drt-api-expected.txt Adding LayoutTests/animations/animation-controller-drt-api.html Sending LayoutTests/platform/win/Skipped Sending WebCore/ChangeLog Sending WebCore/WebCore.base.exp Sending WebCore/page/animation/AnimationController.cpp Sending WebCore/page/animation/AnimationController.h Sending WebCore/page/animation/CompositeAnimation.cpp Sending WebCore/page/animation/CompositeAnimation.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/WebView/WebFrame.mm Sending WebKit/mac/WebView/WebFramePrivate.h Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/LayoutTestController.cpp Sending WebKitTools/DumpRenderTree/LayoutTestController.h Sending WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm Sending WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp Transmitting file data .................. Committed revision 39669. |