Bug 231255 – [ iOS 15 ] ASSERTION FAILED: isRunningTest(WebCore::applicationBundleIdentifier())

• Component: New Bugs
• Status: RESOLVED FIXED

http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html

Is a flaky crash on iOS 15.

History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-cross-site-image-redirect.html

Stderr:

ASSERTION FAILED: isRunningTest(WebCore::applicationBundleIdentifier())
/Volumes/Data/worker/ios-simulator-15-debug/build/Source/WebKit/NetworkProcess/NetworkSession.cpp(448) : void WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting(WTF::String &&)
1   0x13fda0e99 WTFCrash
2   0x125273c6b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x1260dc48e WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting(WTF::String&&)
4   0x1260122b9 WebKit::NetworkProcess::setPrivateClickMeasurementAppBundleIDForTesting(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&)
5   0x12595a578 void IPC::callMemberFunctionImpl<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&), void (), std::__1::tuple<PAL::SessionID, WTF::String>, 0ul, 1ul>(WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&), WTF::CompletionHandler<void ()>&&, std::__1::tuple<PAL::SessionID, WTF::String>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>)
6   0x125958ec2 void IPC::callMemberFunction<WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&), void (), std::__1::tuple<PAL::SessionID, WTF::String>, std::__1::integer_sequence<unsigned long, 0ul, 1ul> >(std::__1::tuple<PAL::SessionID, WTF::String>&&, WTF::CompletionHandler<void ()>&&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&))
7   0x1258c0bf6 void IPC::handleMessageAsync<Messages::NetworkProcess::SetPrivateClickMeasurementAppBundleIDForTesting, WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&)>(IPC::Connection&, IPC::Decoder&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(PAL::SessionID, WTF::String&&, WTF::CompletionHandler<void ()>&&))
8   0x1258b5e50 WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&)
9   0x1260006fe WebKit::NetworkProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
10  0x1253015ee IPC::Connection::dispatchMessage(IPC::Decoder&)
11  0x125301db2 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)
12  0x1253023ad IPC::Connection::dispatchOneIncomingMessage()
13  0x125322815 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_12::operator()()
14  0x125322729 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_12, void>::call()
15  0x13fdcd6e2 WTF::Function<void ()>::operator()() const
16  0x13fe5525e WTF::RunLoop::performWork()
17  0x13fe59a8e WTF::RunLoop::performWork(void*)
18  0x1063d0e25 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
19  0x1063d0d1d __CFRunLoopDoSource0
20  0x1063d01f2 __CFRunLoopDoSources0
21  0x1063ca951 __CFRunLoopRun
22  0x1063ca103 CFRunLoopRunSpecific
23  0x106d1241c -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
24  0x106d12638 -[NSRunLoop(NSRunLoop) run]
25  0x10781105f _xpc_objc_main
26  0x107813050 xpc_main
27  0x12611e52a WebKit::XPCServiceMain(int, char const**)
28  0x127a13a7b WKXPCServiceMain
29  0x105e8cd42 main
30  0x105e9ee1e
31  0x1

Created attachment 440268 [details]
crash log

[Radar WebKit Bug Importer]

<rdar://problem/83903881>

The test is showing up on EWS as a pre-existing failure. Marked expectations to speed up EWS https://trac.webkit.org/changeset/283569/webkit

I was not able to reproduce the crash locally using run-webkit-tests --iterations 100 --exit-after-n-crashes-or-timeouts 1 --ios-simulator http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html --force

According to the history, the test first crash at r283321. From the crash log, it think the crash might have started at https://trac.webkit.org/changeset/283316/webkit.

Or https://trac.webkit.org/changeset/283295/webkit

*** Bug 231748 has been marked as a duplicate of this bug. ***

[John Wilander]

Fixed in: https://trac.webkit.org/changeset/284846/webkit
Reverted test expectation in: https://trac.webkit.org/changeset/284848/webkit

[John Wilander]

We may need another test fix for layout test that use <!-- webkit-test-runner [ enableInAppBrowserPrivacy=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier isAppBoundWebView=true ] -->

_clearApplicationBundleIdentifierTestingOverride() needs to reset the ID in the network process. I've asked Kate to have a look.

[Eric Hutchison]

Test is still crashing after commit: https://trac.webkit.org/changeset/284846/webkit.

[Eric Hutchison]

reset test expectations at https://trac.webkit.org/changeset/284881/webkit

[John Wilander]

Created attachment 442533 [details]
[fast-cq] Patch for landing

[John Wilander]

Kate's fix in https://commits.webkit.org/r284897 should now have addressed the assertion failure.

[EWS]

Committed r284899 (243576@main): <https://commits.webkit.org/243576@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442533 [details].