Bug 231254

Summary: Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2021-10-05 14:20:17 PDT 
Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Comment 1 Alex Christensen 2021-10-05 14:21:51 PDT 
Created attachment 440267 [details]
Patch
Comment 2 Kate Cheney 2021-10-05 16:08:38 PDT 
Comment on attachment 440267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440267&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41
> +    bool runningInDaemon() const final { return false; }

Shouldn't this be true?
Comment 3 Alex Christensen 2021-10-05 17:02:37 PDT 
Comment on attachment 440267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440267&action=review

>> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41
>> +    bool runningInDaemon() const final { return false; }
> 
> Shouldn't this be true?

yes
Comment 4 Alex Christensen 2021-10-05 17:03:44 PDT 
Created attachment 440302 [details]
Patch
Comment 5 Kate Cheney 2021-10-05 17:07:52 PDT 
Comment on attachment 440302 [details]
Patch

r=me
Comment 6 EWS 2021-10-05 18:16:34 PDT 
Committed r283595 (242550@main): <https://commits.webkit.org/242550@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440302 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-05 18:17:18 PDT 
<rdar://problem/83914029>