Bug 231254

Summary: Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2021-10-05 14:20:17 PDT
Do daily activity in AdAttributionDaemon based off of when the xpc activity happens
Attachments
Patch (9.17 KB, patch)
2021-10-05 14:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.17 KB, patch)
2021-10-05 17:03 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-05 14:21:51 PDT
Created attachment 440267 [details] Patch
Kate Cheney
Comment 2 2021-10-05 16:08:38 PDT
Comment on attachment 440267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440267&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41 > + bool runningInDaemon() const final { return false; } Shouldn't this be true?
Alex Christensen
Comment 3 2021-10-05 17:02:37 PDT
Comment on attachment 440267 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440267&action=review >> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDaemonClient.h:41 >> + bool runningInDaemon() const final { return false; } > > Shouldn't this be true? yes
Alex Christensen
Comment 4 2021-10-05 17:03:44 PDT
Created attachment 440302 [details] Patch
Kate Cheney
Comment 5 2021-10-05 17:07:52 PDT
Comment on attachment 440302 [details] Patch r=me
EWS
Comment 6 2021-10-05 18:16:34 PDT
Committed r283595 (242550@main): <https://commits.webkit.org/242550@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440302 [details].
Radar WebKit Bug Importer
Comment 7 2021-10-05 18:17:18 PDT
<rdar://problem/83914029>
Note You need to log in before you can comment on or make changes to this bug.