Bug 231238

Summary:

Share macOS code between ScrollAnimator::handleWheelEvent() and ScrollingEffectsController::handleWheelEvent()

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Scrolling

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, clord, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, mrobinson, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Simon Fraser (smfr) 2021-10-05 10:14:36 PDT

There's duplicate but slightly different code here and it needs to be cleaned up. This code is hit for some non-accelerated cases like list box scrolling.

Comment 1 Radar WebKit Bug Importer 2021-10-12 10:15:29 PDT

<rdar://problem/84153262>

Comment 2 Simon Fraser (smfr) 2021-12-20 19:59:00 PST

*** Bug 234495 has been marked as a duplicate of this bug. ***

Comment 3 Simon Fraser (smfr) 2021-12-22 16:32:00 PST

Created attachment 447841 [details]
Patch

Comment 4 Wenson Hsieh 2021-12-22 16:46:14 PST

Comment on attachment 447841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447841&action=review

r=mews

> Source/WebCore/ChangeLog:18
> +        The ScrollAnimatorMac::handleWheelEvent() override now simply class into the base class,

"class into" => "calls into"

Comment 5 Simon Fraser (smfr) 2021-12-23 09:20:20 PST

https://trac.webkit.org/changeset/287397/webkit