| Summary: | Replace document.topDocument().securityOrigin() with document.topOrigin() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||
| Component: | DOM | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, cmarcelo, esprehn+autocc, ews-watchlist, japhet, kangil.han, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 440185 [details]
Patch
Comment on attachment 440185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440185&action=review > Source/WebCore/dom/DocumentStorageAccess.cpp:92 > + auto& topSecurityOrigin = m_document.topOrigin(); topSecurityOrigin is only used once, can we remove this variable? > Source/WebCore/dom/DocumentStorageAccess.cpp:162 > + auto& topSecurityOrigin = m_document.topOrigin(); Ditto for both topSecurityOrigin and topDocument Created attachment 440191 [details]
Patch
Committed r283544 (242509@main): <https://commits.webkit.org/242509@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440191 [details]. |
Document::topOrigin() is defined as: SecurityOrigin& topOrigin() const final { return topDocument().securityOrigin(); }