Bug 23122

Summary:

platform/animation/Animation.cpp includes RenderStyle.h: bad dependency

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Chris Marrin <cmarrin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch	eric: review+

Description Simon Fraser (smfr) 2009-01-05 13:33:36 PST

Animation.cpp breaks the platform abstraction by pulling in RenderStyle.h, for initialAnimationDelay() and friends.

Comment 1 Chris Marrin 2009-01-07 16:57:18 PST

Created attachment 26514 [details]
patch

Comment 2 Eric Seidel (no email) 2009-01-07 16:58:52 PST

Comment on attachment 26514 [details]
patch

Looks good.

Comment 3 Chris Marrin 2009-01-07 17:38:26 PST

Sending        WebCore/ChangeLog
Sending        WebCore/css/CSSComputedStyleDeclaration.cpp
Sending        WebCore/css/CSSHelper.h
Sending        WebCore/css/CSSStyleSelector.cpp
Sending        WebCore/platform/animation/Animation.cpp
Sending        WebCore/platform/animation/Animation.h
Sending        WebCore/rendering/style/RenderStyle.h
Transmitting file data .......
Committed revision 39696.