Bug 231211

Summary: Add support for Wasm exceptions in the Air generator
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234909    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
patch
ews-feeder: commit-queue-
patch
none
patch none

Tadeu Zagallo
Reported 2021-10-04 22:45:30 PDT
...
Attachments
WIP (20.24 KB, patch)
2022-01-05 16:14 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (20.55 KB, patch)
2022-01-05 16:39 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (31.41 KB, patch)
2022-01-05 18:18 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (39.07 KB, patch)
2022-01-05 19:03 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (43.72 KB, patch)
2022-01-06 11:44 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (46.20 KB, patch)
2022-01-06 12:08 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (46.66 KB, patch)
2022-01-06 12:48 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (48.22 KB, patch)
2022-01-06 14:46 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (49.15 KB, patch)
2022-01-06 16:40 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (69.17 KB, patch)
2022-01-06 22:30 PST, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (75.87 KB, patch)
2022-01-07 12:52 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (75.88 KB, patch)
2022-01-07 12:56 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-11 22:46:42 PDT
<rdar://problem/84132861>
Saam Barati
Comment 2 2022-01-04 13:32:46 PST
I think ima do this.
Saam Barati
Comment 3 2022-01-05 16:14:46 PST
Created attachment 448449 [details] WIP
Saam Barati
Comment 4 2022-01-05 16:39:28 PST
Created attachment 448453 [details] WIP
Saam Barati
Comment 5 2022-01-05 18:18:14 PST
Created attachment 448461 [details] WIP
Saam Barati
Comment 6 2022-01-05 19:03:45 PST
Created attachment 448462 [details] WIP
Saam Barati
Comment 7 2022-01-06 11:44:45 PST
Created attachment 448516 [details] WIP
Saam Barati
Comment 8 2022-01-06 12:08:41 PST
Created attachment 448522 [details] WIP
Saam Barati
Comment 9 2022-01-06 12:48:53 PST
Created attachment 448528 [details] WIP
Saam Barati
Comment 10 2022-01-06 14:46:00 PST
Created attachment 448538 [details] WIP At least one test runs.
Saam Barati
Comment 11 2022-01-06 16:40:11 PST
Created attachment 448545 [details] WIP Patch is ready, just gotta clean some stuff up. But first, gotta fix https://bugs.webkit.org/show_bug.cgi?id=234909
Saam Barati
Comment 12 2022-01-06 22:30:32 PST
Created attachment 448562 [details] patch
Saam Barati
Comment 13 2022-01-07 10:41:34 PST
JSC failure might be x86_64 specific. Looking into it. Doesn't reproduce on my M1 Mac for an arm64 binary
Saam Barati
Comment 14 2022-01-07 12:52:28 PST
Created attachment 448621 [details] patch
Saam Barati
Comment 15 2022-01-07 12:56:27 PST
Created attachment 448622 [details] patch
EWS
Comment 16 2022-01-07 17:58:14 PST
Committed r287801 (245854@main): <https://commits.webkit.org/245854@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448622 [details].
Saam Barati
Comment 17 2022-01-07 19:43:16 PST
fix debug assert in: https://trac.webkit.org/changeset/287806/webkit
Note You need to log in before you can comment on or make changes to this bug.