Bug 231203

Summary: Add support for '-webkit-appearance: auto'
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: CSSAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, mifenton, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231383    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
wenson_hsieh: review+
Patch for landing
none
Patch for landing none

Aditya Keerthi
Reported 2021-10-04 18:06:30 PDT
https://www.w3.org/TR/css-ui-4/#valdef-appearance-auto
Attachments
Patch (32.18 KB, patch)
2021-10-04 18:10 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (32.53 KB, patch)
2021-10-04 18:53 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (35.08 KB, patch)
2021-10-05 12:16 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (17.39 KB, patch)
2021-10-07 12:15 PDT, Aditya Keerthi 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (17.39 KB, patch)
2021-10-08 15:08 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.40 KB, patch)
2021-10-08 15:13 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-10-04 18:06:42 PDT
rdar://83696133
Aditya Keerthi
Comment 2 2021-10-04 18:10:36 PDT
Created attachment 440134 [details] Patch
Aditya Keerthi
Comment 3 2021-10-04 18:53:39 PDT
Created attachment 440143 [details] Patch
Aditya Keerthi
Comment 4 2021-10-05 12:16:37 PDT
Created attachment 440245 [details] Patch
Aditya Keerthi
Comment 5 2021-10-07 12:15:31 PDT
Created attachment 440522 [details] Patch
Wenson Hsieh
Comment 6 2021-10-08 14:24:54 PDT
Comment on attachment 440522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440522&action=review > Source/WebCore/rendering/RenderTheme.cpp:294 > + auto& element = *elementPtr; Nit - I think current guidelines (https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html) recommend storing this as a `Ref` instead of a raw reference. > Source/WebCore/rendering/RenderTheme.cpp:300 > + return PushButtonPart; Just as an aside — we should consider making these strongly typed `enum class` at some point.
Aditya Keerthi
Comment 7 2021-10-08 15:08:24 PDT
Created attachment 440680 [details] Patch for landing
Aditya Keerthi
Comment 8 2021-10-08 15:10:58 PDT
(In reply to Wenson Hsieh from comment #6) > Comment on attachment 440522 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440522&action=review > > > Source/WebCore/rendering/RenderTheme.cpp:294 > > + auto& element = *elementPtr; > > Nit - I think current guidelines > (https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html) > recommend storing this as a `Ref` instead of a raw reference. Done. > > Source/WebCore/rendering/RenderTheme.cpp:300 > > + return PushButtonPart; > > Just as an aside — we should consider making these strongly typed `enum > class` at some point. Filed https://bugs.webkit.org/show_bug.cgi?id=231457 to do this cleanup.
Aditya Keerthi
Comment 9 2021-10-08 15:13:11 PDT
Created attachment 440681 [details] Patch for landing
EWS
Comment 10 2021-10-08 18:39:38 PDT
Committed r283858 (242736@main): <https://commits.webkit.org/242736@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440681 [details].
Note You need to log in before you can comment on or make changes to this bug.