Bug 231203

Summary: Add support for '-webkit-appearance: auto'
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: CSSAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, mifenton, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 231383    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
wenson_hsieh: review+
Patch for landing
none
Patch for landing none

Comment 1 Aditya Keerthi 2021-10-04 18:06:42 PDT 
rdar://83696133
Comment 2 Aditya Keerthi 2021-10-04 18:10:36 PDT 
Created attachment 440134 [details]
Patch
Comment 3 Aditya Keerthi 2021-10-04 18:53:39 PDT 
Created attachment 440143 [details]
Patch
Comment 4 Aditya Keerthi 2021-10-05 12:16:37 PDT 
Created attachment 440245 [details]
Patch
Comment 5 Aditya Keerthi 2021-10-07 12:15:31 PDT 
Created attachment 440522 [details]
Patch
Comment 6 Wenson Hsieh 2021-10-08 14:24:54 PDT 
Comment on attachment 440522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440522&action=review

> Source/WebCore/rendering/RenderTheme.cpp:294
> +    auto& element = *elementPtr;

Nit - I think current guidelines (https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html) recommend storing this as a `Ref` instead of a raw reference.

> Source/WebCore/rendering/RenderTheme.cpp:300
> +            return PushButtonPart;

Just as an aside — we should consider making these strongly typed `enum class` at some point.
Comment 7 Aditya Keerthi 2021-10-08 15:08:24 PDT 
Created attachment 440680 [details]
Patch for landing
Comment 8 Aditya Keerthi 2021-10-08 15:10:58 PDT 
(In reply to Wenson Hsieh from comment #6)
> Comment on attachment 440522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440522&action=review
> 
> > Source/WebCore/rendering/RenderTheme.cpp:294
> > +    auto& element = *elementPtr;
> 
> Nit - I think current guidelines
> (https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html)
> recommend storing this as a `Ref` instead of a raw reference.

Done.
 
> > Source/WebCore/rendering/RenderTheme.cpp:300
> > +            return PushButtonPart;
> 
> Just as an aside — we should consider making these strongly typed `enum
> class` at some point.

Filed https://bugs.webkit.org/show_bug.cgi?id=231457 to do this cleanup.
Comment 9 Aditya Keerthi 2021-10-08 15:13:11 PDT 
Created attachment 440681 [details]
Patch for landing
Comment 10 EWS 2021-10-08 18:39:38 PDT 
Committed r283858 (242736@main): <https://commits.webkit.org/242736@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440681 [details].