Bug 231198

Summary:

[LFC][IFC] Move tryBreaking*Run logic to standalone functions

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2021-10-04 16:22:40 PDT

InlineContentBreaker::processOverflowingContentWithText is getting too large

Comment 1 zalan 2021-10-04 16:27:10 PDT

Created attachment 440120 [details]
Patch

Comment 2 Antti Koivisto 2021-10-05 06:42:24 PDT

Comment on attachment 440120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440120&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:-367
> -    auto tryBreakingNextOverflowingRuns = [&]() -> std::optional<OverflowingTextContent::BreakingPosition> {

:sadlambda:

Comment 3 zalan 2021-10-05 07:42:43 PDT

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 440120 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440120&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:-367
> > -    auto tryBreakingNextOverflowingRuns = [&]() -> std::optional<OverflowingTextContent::BreakingPosition> {
> 
> :sadlambda:
:(

Comment 4 EWS 2021-10-05 07:50:05 PDT

Committed r283549 (242514@main): <https://commits.webkit.org/242514@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440120 [details].

Comment 5 Radar WebKit Bug Importer 2021-10-05 07:51:19 PDT

<rdar://problem/83885877>