Bug 231188

Summary:

[clang 13] Suppress sign comparison warnings

Product:

WebKit

Reporter:

Basuke Suzuki <Basuke.Suzuki>

Component:

Platform

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, pangle, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Basuke Suzuki 2021-10-04 12:16:10 PDT

C:/PSDev/webkit/Source/JavaScriptCore\inspector/remote/socket/RemoteInspectorSocket.cpp:273:68: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
        if (FileSystem::readFromFile(handle, buffer.data(), *size) == *size)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~
1 warning generated.

Comment 1 Radar WebKit Bug Importer 2021-10-11 12:17:24 PDT

<rdar://problem/84110570>

Comment 2 Chris Dumez 2021-10-19 10:54:08 PDT

Created attachment 441756 [details]
Patch

Comment 3 EWS 2021-10-19 12:49:58 PDT

Committed r284480 (243239@main): <https://commits.webkit.org/243239@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441756 [details].