Bug 231188

Summary: [clang 13] Suppress sign comparison warnings
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, pangle, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Basuke Suzuki
Reported 2021-10-04 12:16:10 PDT
C:/PSDev/webkit/Source/JavaScriptCore\inspector/remote/socket/RemoteInspectorSocket.cpp:273:68: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] if (FileSystem::readFromFile(handle, buffer.data(), *size) == *size) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~ 1 warning generated.
Attachments
Patch (1.64 KB, patch)
2021-10-19 10:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-11 12:17:24 PDT
<rdar://problem/84110570>
Chris Dumez
Comment 2 2021-10-19 10:54:08 PDT
Created attachment 441756 [details] Patch
EWS
Comment 3 2021-10-19 12:49:58 PDT
Committed r284480 (243239@main): <https://commits.webkit.org/243239@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441756 [details].
Note You need to log in before you can comment on or make changes to this bug.