Bug 231186 – Don't use namespace WebCore::XPath at global scope

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Don't use namespace WebCore::XPath at global scope

[Alex Christensen]

Created attachment 440084 [details]
Patch

[Basuke Suzuki]

I'm checking right now.

[Basuke Suzuki]

In PlayStation port, it still has these compile errors:

C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:58: error: expected ')'
    bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const;
                                                         ^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:24: note: to match this '('
    bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const;
                       ^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:48: error: expected ')'
    FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const;
                                               ^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:33: note: to match this '('
    FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const;
                                ^
2 errors generated.

[Ross Kirsling]

Perhaps the issue is the remaining `using namespace`s at XPathGrammar.y:51?

[EWS]

Committed r283635 (242586@main): <https://commits.webkit.org/242586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440084 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83942126>