| Summary: | Don't use namespace WebCore::XPath at global scope | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | Basuke.Suzuki, ross.kirsling, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 231302 | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2021-10-04 11:53:36 PDT
Created attachment 440084 [details]
Patch
I'm checking right now. In PlayStation port, it still has these compile errors:
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:58: error: expected ')'
bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const;
^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:24: note: to match this '('
bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const;
^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:48: error: expected ')'
FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const;
^
C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:33: note: to match this '('
FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const;
^
2 errors generated.
Perhaps the issue is the remaining `using namespace`s at XPathGrammar.y:51? Committed r283635 (242586@main): <https://commits.webkit.org/242586@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440084 [details]. |