Bug 231172

Summary:	REGRESSION (r283476): [ iOS macOS Debug ] TestWTF failures in RetainPtrARC and TypeCastsCocoaARC
Product:	WebKit	Reporter:	ayumi_kojima
Component:	Web Template Framework	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	darin, ddkilzer, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	230406
Bug Blocks:	231251

Description ayumi_kojima 2021-10-04 08:23:30 PDT

TestWTF.TypeCastsCocoa.checked_objc_cast

Is constantly failing on iOS Release and macOS Release.

History: https://results.webkit.org/?suite=api-tests&test=TestWTF.TypeCastsCocoa.checked_objc_cast

According to the history, it looks like the test started failing at https://trac.webkit.org/changeset/283476/webkit.

Stdio:

Failed
    TestWTF.TypeCastsCocoa.checked_objc_cast
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:121
        Expected equality of these values:
          1L
            Which is: 1
          CFGetRetainCount((CFTypeRef)objectNSPtr)
            Which is: 2
        
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:135
        Expected equality of these values:
          1L
            Which is: 1
          CFGetRetainCount((CFTypeRef)objectNSPtr)
            Which is: 2

Comment 1 Radar WebKit Bug Importer 2021-10-04 08:23:50 PDT

<rdar://problem/83836549>

Comment 2 ayumi_kojima 2021-10-04 13:42:26 PDT

TestWTF.TypeCastsCocoaARC.dynamic_objc_cast_RetainPtr
TestWTF.RetainPtrARC.AdoptNS
TestWTF.RetainPtrARC.RetainPtrNS
TestWTF.TypeCastsCocoaARC.bridge_id_cast
TestWTF.TypeCastsCocoaARC.checked_objc_cast
TestWTF.TypeCastsCocoaARC.dynamic_objc_cast

Are also failing constantly on iOS Debug and macOS Debug

History: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWTF.TypeCastsCocoaARC.dynamic_objc_cast_RetainPtr&test=TestWTF.TypeCastsCocoaARC.dynamic_objc_cast&test=TestWTF.TypeCastsCocoaARC.checked_objc_cast&test=TestWTF.TypeCastsCocoaARC.bridge_id_cast&test=TestWTF.RetainPtrARC.RetainPtrNS&test=TestWTF.RetainPtrARC.AdoptNS

Comment 3 David Kilzer (:ddkilzer) 2021-10-05 09:09:12 PDT

Fixed here for checked_objc_cast<> issues:

Committed r283551  <https://trac.webkit.org/changeset/283551/webkit>

Looking at the others now.

Comment 4 David Kilzer (:ddkilzer) 2021-10-05 09:45:17 PDT

Committed r283553 (242518@main): <https://commits.webkit.org/242518@main>

Comment 5 David Kilzer (:ddkilzer) 2021-10-05 09:48:27 PDT

(In reply to David Kilzer (:ddkilzer) from comment #4)
> Committed r283553 (242518@main): <https://commits.webkit.org/242518@main>

Backed out RetainPtrARC.mm and TypeCastsCocoaARC.mm until I can fix the issues in Debug builds (to make bots green again) since it may take me a bit to get that done.

Will file a new bug to add the tests back with the fixes.

Comment 6 David Kilzer (:ddkilzer) 2021-10-07 08:04:13 PDT

(In reply to David Kilzer (:ddkilzer) from comment #5)
> (In reply to David Kilzer (:ddkilzer) from comment #4)
> > Committed r283553 (242518@main): <https://commits.webkit.org/242518@main>
> 
> Backed out RetainPtrARC.mm and TypeCastsCocoaARC.mm until I can fix the
> issues in Debug builds (to make bots green again) since it may take me a bit
> to get that done.
> 
> Will file a new bug to add the tests back with the fixes.

Bug 231251: Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF