Bug 231140

Summary: Use ScrollClamping in more places in scrolling code
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Severity: Normal CC: changseok, cmarcelo, esprehn+autocc, ews-watchlist, fred.wang, glenn, jamesr, koivisto, kondapallykalyan, luiz, pdr, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch koivisto: review+

Description Simon Fraser (smfr) 2021-10-03 11:41:36 PDT
Use ScrollClamping in more places in scrolling code
Comment 1 Simon Fraser (smfr) 2021-10-03 11:43:10 PDT
Created attachment 440010 [details]
Comment 2 Antti Koivisto 2021-10-04 10:42:55 PDT
Comment on attachment 440010 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=440010&action=review

> Source/WebCore/platform/ScrollableArea.h:400
> -    unsigned m_constrainsScrollingToContentEdge : 1;
> +    unsigned m_scrollClamping : 1; // ScrollClamping
>      unsigned m_inLiveResize : 1;

These should be regular typed fields instead of bitfields. We don't have enough ScrollAreas for its size to matter.

They should then be initialized here instead of constructor.
Comment 3 Simon Fraser (smfr) 2021-10-04 16:38:36 PDT
Comment 4 Radar WebKit Bug Importer 2021-10-04 16:39:46 PDT