Bug 231129

Summary: Setting and RuntimeEnabledFeature names in IDL files should match those used elsewhere
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, benjamin, calvaris, cdumez, cfleizach, changseok, cmarcelo, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, hta, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pangle, philipj, samuel_white, sam, sergio, simon.fraser, tommyw, toyoshim, webkit-bug-importer, youennf, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2021-10-02 19:29:35 PDT
Setting and RuntimeEnabledFeature names in IDL files should match those used elsewhere
Attachments
Patch (299.51 KB, patch)
2021-10-02 19:32 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (300.36 KB, patch)
2021-10-02 20:29 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-10-02 19:32:34 PDT
Created attachment 439983 [details] Patch
Tim Horton
Comment 2 2021-10-02 19:34:42 PDT
This is a bit of a subjective thing, so I want to hear what others think! I will note that I have missed settings being used in IDL files a number of times over the years (when grepping for the setting getter name), thus the motivation.
Sam Weinig
Comment 3 2021-10-02 20:15:00 PDT
rs=me. Been meaning to do this for ages. I always get tripped up when prepping for things.
Sam Weinig
Comment 4 2021-10-02 20:15:21 PDT
Please fix the bindings tests though :).
Tim Horton
Comment 5 2021-10-02 20:29:54 PDT
Created attachment 439990 [details] Patch
EWS
Comment 6 2021-10-03 00:16:38 PDT
Committed r283463 (242442@main): <https://commits.webkit.org/242442@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439990 [details].
Radar WebKit Bug Importer
Comment 7 2021-10-03 00:17:17 PDT
<rdar://problem/83807157>
Note You need to log in before you can comment on or make changes to this bug.