Bug 231129 - Setting and RuntimeEnabledFeature names in IDL files should match those used elsewhere
Summary: Setting and RuntimeEnabledFeature names in IDL files should match those used ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-02 19:29 PDT by Tim Horton
Modified: 2021-10-03 00:17 PDT (History)
39 users (show)

See Also:

Attachments
Patch (299.51 KB, patch)
2021-10-02 19:32 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (300.36 KB, patch)
2021-10-02 20:29 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-10-02 19:29:35 PDT 
Setting and RuntimeEnabledFeature names in IDL files should match those used elsewhere
Comment 1 Tim Horton 2021-10-02 19:32:34 PDT 
Created attachment 439983 [details]
Patch
Comment 2 Tim Horton 2021-10-02 19:34:42 PDT 
This is a bit of a subjective thing, so I want to hear what others think!

I will note that I have missed settings being used in IDL files a number of times over the years (when grepping for the setting getter name), thus the motivation.
Comment 3 Sam Weinig 2021-10-02 20:15:00 PDT 
rs=me. Been meaning to do this for ages. I always get tripped up when prepping for things.
Comment 4 Sam Weinig 2021-10-02 20:15:21 PDT 
Please fix the bindings tests though :).
Comment 5 Tim Horton 2021-10-02 20:29:54 PDT 
Created attachment 439990 [details]
Patch
Comment 6 EWS 2021-10-03 00:16:38 PDT 
Committed r283463 (242442@main): <https://commits.webkit.org/242442@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439990 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-03 00:17:17 PDT 
<rdar://problem/83807157>