Bug 231100

Summary:

[LFC][IFC] Pass in the correct style when adding a run to Line

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-10-01 13:56:16 PDT

first-line

Comment 1 zalan 2021-10-01 13:58:29 PDT

Created attachment 439907 [details]
Patch

Comment 2 Antti Koivisto 2021-10-02 05:35:44 PDT

Comment on attachment 439907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439907&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:821
> +        auto& style = [&] () -> const RenderStyle& {
> +            return m_isFirstLine ? inlineItem.firstLineStyle() : inlineItem.style();
> +        }();

Not sure if there is such a thing as overuse of lambda but this might be one.

Comment 3 zalan 2021-10-02 06:15:37 PDT

Created attachment 439964 [details]
Patch

Comment 4 EWS 2021-10-02 06:51:54 PDT

Committed r283442 (242429@main): <https://commits.webkit.org/242429@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439964 [details].

Comment 5 Radar WebKit Bug Importer 2021-10-02 06:52:16 PDT

<rdar://problem/83797765>