Bug 231100

Summary: [LFC][IFC] Pass in the correct style when adding a run to Line
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2021-10-01 13:56:16 PDT
first-line
Attachments
Patch (3.71 KB, patch)
2021-10-01 13:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.62 KB, patch)
2021-10-02 06:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-10-01 13:58:29 PDT
Created attachment 439907 [details] Patch
Antti Koivisto
Comment 2 2021-10-02 05:35:44 PDT
Comment on attachment 439907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439907&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:821 > + auto& style = [&] () -> const RenderStyle& { > + return m_isFirstLine ? inlineItem.firstLineStyle() : inlineItem.style(); > + }(); Not sure if there is such a thing as overuse of lambda but this might be one.
alan
Comment 3 2021-10-02 06:15:37 PDT
Created attachment 439964 [details] Patch
EWS
Comment 4 2021-10-02 06:51:54 PDT
Committed r283442 (242429@main): <https://commits.webkit.org/242429@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439964 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-02 06:52:16 PDT
<rdar://problem/83797765>
Note You need to log in before you can comment on or make changes to this bug.