| Summary: | Enable PCM debug mode per WebsiteDataStore instead of process-global | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | katherine_cheney, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2021-10-01 13:29:15 PDT
Created attachment 439903 [details]
Patch
Created attachment 439977 [details]
Patch
Comment on attachment 439977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review LGTM > Source/WebKit/NetworkProcess/NetworkSession.cpp:431 > + auto message = enabled ? "[Private Click Measurement] Turned Debug Mode on."_s : "[Private Click Measurement] Turned Debug Mode off."_s; Seems like there was an isEphemeral() check in the previous code that got lost here, not sure how important that is. Comment on attachment 439977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review >> Source/WebKit/NetworkProcess/NetworkSession.cpp:431 >> + auto message = enabled ? "[Private Click Measurement] Turned Debug Mode on."_s : "[Private Click Measurement] Turned Debug Mode off."_s; > > Seems like there was an isEphemeral() check in the previous code that got lost here, not sure how important that is. Yeah, it's just for broadcasting debug messages to the web inspector, and we now only broadcast to the current session, which effectively does the same thing. Comment on attachment 439977 [details] Patch http://trac.webkit.org/r283504 I manually verified this on macOS. I manually verified this on iOS also. |