Bug 231096

Summary: Enable PCM debug mode per WebsiteDataStore instead of process-global
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch katherine_cheney: review+

Alex Christensen
Reported 2021-10-01 13:29:15 PDT
Enable PCM debug mode per WebsiteDataStore instead of process-global
Attachments
Patch (19.88 KB, patch)
2021-10-01 13:30 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.91 KB, patch)
2021-10-02 16:17 PDT, Alex Christensen 		katherine_cheney: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-01 13:30:12 PDT
Created attachment 439903 [details] Patch
Alex Christensen
Comment 2 2021-10-02 16:17:48 PDT
Created attachment 439977 [details] Patch
Kate Cheney
Comment 3 2021-10-04 09:28:03 PDT
Comment on attachment 439977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review LGTM > Source/WebKit/NetworkProcess/NetworkSession.cpp:431 > + auto message = enabled ? "[Private Click Measurement] Turned Debug Mode on."_s : "[Private Click Measurement] Turned Debug Mode off."_s; Seems like there was an isEphemeral() check in the previous code that got lost here, not sure how important that is.
Alex Christensen
Comment 4 2021-10-04 09:59:05 PDT
Comment on attachment 439977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439977&action=review >> Source/WebKit/NetworkProcess/NetworkSession.cpp:431 >> + auto message = enabled ? "[Private Click Measurement] Turned Debug Mode on."_s : "[Private Click Measurement] Turned Debug Mode off."_s; > > Seems like there was an isEphemeral() check in the previous code that got lost here, not sure how important that is. Yeah, it's just for broadcasting debug messages to the web inspector, and we now only broadcast to the current session, which effectively does the same thing.
Alex Christensen
Comment 5 2021-10-04 10:39:00 PDT
Comment on attachment 439977 [details] Patch http://trac.webkit.org/r283504
Radar WebKit Bug Importer
Comment 6 2021-10-04 11:04:03 PDT
<rdar://problem/83843839>
Alex Christensen
Comment 7 2021-10-04 11:48:14 PDT
I manually verified this on macOS.
Alex Christensen
Comment 8 2021-10-05 10:26:35 PDT
I manually verified this on iOS also.
Note You need to log in before you can comment on or make changes to this bug.