Bug 231086

Summary:

Begin migration from WTF::Variant to std::variant

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, alecflett, andresg_22, apinheiro, beidson, benjamin, berto, bugs-noreply, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, darin, dino, dmazzoni, don.olmstead, eocanha, eric.carlson, esprehn+autocc, ews-watchlist, fujii.hironori, galpeter, glenn, gustavo, gyuyoung.kim, hi, hta, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, pdr, philipj, pnormand, rbuis, saam, samuel_white, sergio, svillar, tommyw, tzagallo, vjaquez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2021-10-01 10:56:53 PDT

Begin migration from WTF::Variant to std::variant

Attachments
Patch (189.82 KB, patch) 2021-10-01 10:57 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (159.77 KB, patch) 2021-10-01 15:08 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (164.36 KB, patch) 2021-10-03 14:54 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (163.92 KB, patch) 2021-10-03 17:15 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (168.11 KB, patch) 2021-10-04 14:12 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (162.49 KB, patch) 2021-10-04 16:39 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (86.77 KB, patch) 2021-10-11 18:04 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2021-10-01 10:57:52 PDT

Created attachment 439878 [details] Patch

Alex Christensen

Comment 2 2021-10-01 15:08:42 PDT

Created attachment 439916 [details] Patch

Alex Christensen

Comment 3 2021-10-01 16:26:09 PDT

I'd appreciate it if someone could get this compiling on Windows and/or Linux. I think I've done the bulk of the work, but this is a bit much for iterating on EWS. The biggest thing was that visitor lambdas need to return the exact same type now.

Fujii Hironori

Comment 4 2021-10-03 14:54:33 PDT

Created attachment 440020 [details] Patch

Fujii Hironori

Comment 5 2021-10-03 17:15:52 PDT

Created attachment 440027 [details] Patch

Alex Christensen

Comment 6 2021-10-04 10:07:42 PDT

Thanks, Fujii. I added some linux developers who have recently contributed to WebKit.

Philippe Normand

Comment 7 2021-10-04 13:26:28 PDT

GTK diff: http://sprunge.us/7UCiuf