Bug 231086

Summary: Begin migration from WTF::Variant to std::variant
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, andresg_22, apinheiro, beidson, benjamin, berto, bugs-noreply, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, darin, dino, dmazzoni, don.olmstead, eocanha, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, gyuyoung.kim, hi, Hironori.Fujii, hta, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, pdr, philipj, pnormand, rbuis, saam, samuel_white, sergio, svillar, tommyw, tzagallo, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2021-10-01 10:56:53 PDT 
Begin migration from WTF::Variant to std::variant
Comment 1 Alex Christensen 2021-10-01 10:57:52 PDT 
Created attachment 439878 [details]
Patch
Comment 2 Alex Christensen 2021-10-01 15:08:42 PDT 
Created attachment 439916 [details]
Patch
Comment 3 Alex Christensen 2021-10-01 16:26:09 PDT 
I'd appreciate it if someone could get this compiling on Windows and/or Linux.  I think I've done the bulk of the work, but this is a bit much for iterating on EWS.  The biggest thing was that visitor lambdas need to return the exact same type now.
Comment 4 Fujii Hironori 2021-10-03 14:54:33 PDT 
Created attachment 440020 [details]
Patch
Comment 5 Fujii Hironori 2021-10-03 17:15:52 PDT 
Created attachment 440027 [details]
Patch
Comment 6 Alex Christensen 2021-10-04 10:07:42 PDT 
Thanks, Fujii.  I added some linux developers who have recently contributed to WebKit.
Comment 7 Philippe Normand 2021-10-04 13:26:28 PDT 
GTK diff: http://sprunge.us/7UCiuf
Comment 8 Alex Christensen 2021-10-04 14:12:12 PDT 
Created attachment 440103 [details]
Patch
Comment 9 Alex Christensen 2021-10-04 16:39:22 PDT 
Created attachment 440123 [details]
Patch
Comment 10 Alex Christensen 2021-10-05 11:13:32 PDT 
split most of this out into https://bugs.webkit.org/show_bug.cgi?id=231239
Comment 11 Radar WebKit Bug Importer 2021-10-08 10:57:32 PDT 
<rdar://problem/84034814>
Comment 12 Alex Christensen 2021-10-11 18:04:10 PDT 
Created attachment 440867 [details]
Patch
Comment 13 EWS 2021-10-12 08:47:19 PDT 
Committed r283982 (242828@main): <https://commits.webkit.org/242828@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440867 [details].