Bug 231075

Summary: Attribute IOSurfaces created by camera and decoders to responsible WebProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ddkilzer, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220770    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Build fix none

Description youenn fablet 2021-10-01 06:11:18 PDT 
Attribute IOSurfaces created by camera and decoders to responsible WebProcess
Comment 1 youenn fablet 2021-10-01 06:17:40 PDT 
Created attachment 439847 [details]
Patch
Comment 2 EWS 2021-10-01 08:34:28 PDT 
Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439847 [details].
Comment 3 Radar WebKit Bug Importer 2021-10-01 08:35:19 PDT 
<rdar://problem/83767168>
Comment 4 David Kilzer (:ddkilzer) 2021-10-03 14:40:51 PDT 
(In reply to EWS from comment #2)
> Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 439847 [details].

After the build failure from Bug X was fixed, I think (not 100% sure) this change is now causing a different build failure:

./platform/graphics/cocoa/IOSurface.mm:491:76: error: use of undeclared identifier 'kIOSurfaceMemoryLedgerTagGraphics'

<https://build.webkit.org/#/builders/275/builds/117>

It's the only recent change that uses HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY), as kIOSurfaceMemoryLedgerTagGraphics was added for Bug 220770 in r271673 last January.
Comment 5 David Kilzer (:ddkilzer) 2021-10-03 14:41:48 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #4)
> (In reply to EWS from comment #2)
> > Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>
> > 
> > All reviewed patches have been landed. Closing bug and clearing flags on
> > attachment 439847 [details].
> 
> After the build failure from Bug X was fixed,

And Bug X would be Bug 231034 and commit r283480.
Comment 6 David Kilzer (:ddkilzer) 2021-10-03 14:50:21 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #4)
> (In reply to EWS from comment #2)
> > Committed r283369 (242378@main): <https://commits.webkit.org/242378@main>
> > 
> > All reviewed patches have been landed. Closing bug and clearing flags on
> > attachment 439847 [details].
> 
> After the build failure from Bug X was fixed, I think (not 100% sure) this
> change is now causing a different build failure:
> 
> ./platform/graphics/cocoa/IOSurface.mm:491:76: error: use of undeclared
> identifier 'kIOSurfaceMemoryLedgerTagGraphics'
> 
> <https://build.webkit.org/#/builders/275/builds/117>
> 
> It's the only recent change that uses
> HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY), as kIOSurfaceMemoryLedgerTagGraphics
> was added for Bug 220770 in r271673 last January.

I have a fix.
Comment 7 David Kilzer (:ddkilzer) 2021-10-03 14:58:45 PDT 
Reopening to attach new patch.
Comment 8 David Kilzer (:ddkilzer) 2021-10-03 14:58:47 PDT 
Created attachment 440021 [details]
Build fix
Comment 9 David Kilzer (:ddkilzer) 2021-10-03 14:59:18 PDT 
Comment on attachment 440021 [details]
Build fix

Waiting to mark cq+ until iOS, tvOS and watchOS builds are successful.
Comment 10 David Kilzer (:ddkilzer) 2021-10-03 15:07:43 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #9)
> Comment on attachment 440021 [details]
> Build fix
> 
> Waiting to mark cq+ until iOS, tvOS and watchOS builds are successful.

Only the hardware builds need to succeed.  The simulator builds aren't failing.
Comment 11 EWS 2021-10-03 16:03:42 PDT 
Committed r283483 (242456@main): <https://commits.webkit.org/242456@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440021 [details].