Bug 231052 – Stop parsing context-sensitive colors in override-color

• Component: Text
• Status: RESOLVED FIXED

[Myles C. Maxfield]

https://github.com/w3c/csswg-drafts/commit/da9c67d6b2f20a0feba11d9e88cc9d9631bcce73

[Radar WebKit Bug Importer]

<rdar://problem/83746258>

[Myles C. Maxfield]

Created attachment 439954 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Simon Fraser (smfr)]

Comment on attachment 439954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439954&action=review

> Source/WebCore/css/StyleColor.cpp:54
> +    return (id >= CSSValueAqua && id <= CSSValueYellow) || (id >= CSSValueAliceblue && id <= CSSValueYellowgreen) || id == CSSValueGrey || id == CSSValueAlpha || id == CSSValueTransparent;

We should make some helpers to contain these color range tests

> Source/WebCore/css/parser/CSSPropertyParserHelpers.h:118
> +enum class AcceptableColorSyntax : uint8_t {

Not sure I like "Acceptable" here. Might be nicer to just have:

enum class CSSColorType {
  Absolute = 1 << 0,
  Current = 1 << 1,
  System = 1 << 2,
};

consumeColor(CSSParserTokenRange&, const CSSParserContext&, bool acceptQuirkyColors = false, OptionSet<CSSColorTypes> allowedColorTypes)

[Myles C. Maxfield]

Committed r283537 (242502@main): <https://commits.webkit.org/242502@main>