Bug 231023

Summary:

[webkitscmpy] Generate commit message template

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dewei_zhu, jlewis3, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=231345

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

Jonathan Bedard

Reported 2021-09-30 09:14:00 PDT

webkitscmpy should provide support for generating a prepare-commit-msg script. Although this change does not yet provide a replace for prepare-ChangeLog, it does allow us to leverage the existing script while decoupling that script from webkitscmpy.

Attachments
Patch (13.12 KB, patch) 2021-09-30 09:29 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (13.86 KB, patch) 2021-09-30 11:29 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (15.01 KB, patch) 2021-09-30 12:06 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (15.15 KB, patch) 2021-10-06 17:45 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (14.86 KB, patch) 2021-10-13 09:50 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (14.78 KB, patch) 2021-10-14 08:37 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch for landing (3.62 KB, patch) 2021-10-27 17:03 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-09-30 09:25:45 PDT

<rdar://problem/83722871>

Jonathan Bedard

Comment 2 2021-09-30 09:29:55 PDT

Created attachment 439744 [details] Patch

Jonathan Bedard

Comment 3 2021-09-30 10:36:16 PDT

The technique I'm using here is not exactly standard. We want to continue to have `git-webkit setup` be repository agnostic, but we also want repositories to be able to define their own commit message formats. In order to achieve this, we're essentially writing a Python file from scratch. But we would like to retain syntax high-lighting and style-checking for the generated code, which is where the `inspect` module comes in. What we're basically doing is defining a function, then extracting the source code of that function and putting it into the generated file. As an added wrinkle, in order of this to be repository agnostic, if the `git-webkit` entry-point would like to define a script to be used to generate the commit message, that script should be defined relative to `git-webkit`, not the generated script (which could be anywhere on a given machine)

Jonathan Bedard

Comment 4 2021-09-30 11:29:32 PDT

Created attachment 439761 [details] Patch

Jonathan Bedard

Comment 5 2021-09-30 12:06:27 PDT

Created attachment 439765 [details] Patch

Jonathan Bedard

Comment 6 2021-09-30 12:06:42 PDT

Pull-request: https://github.com/WebKit/WebKit/pull/13

Jonathan Bedard

Comment 7 2021-10-06 17:45:49 PDT

Created attachment 440460 [details] Patch