Bug 230975

Summary: Test a font palette identifier of just "--"
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, mmaxfield, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230446    
Attachments:
Description Flags
Patch
none
Patch
thorton: review+
Patch for committing none

Myles C. Maxfield
Reported 2021-09-29 11:55:14 PDT
It's a valid <dashed-ident>.
Attachments
Patch (2.77 KB, patch)
2021-09-30 17:37 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (4.78 KB, patch)
2021-10-01 16:21 PDT, Myles C. Maxfield 		thorton: review+
DetailsFormatted DiffDiff
Patch for committing (4.97 KB, patch)
2021-10-04 23:11 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-29 11:55:36 PDT
<rdar://problem/83681811>
Myles C. Maxfield
Comment 2 2021-09-29 12:18:48 PDT
We should do this for both @font-palette-values and font-palette. These can be parsing tests.
Myles C. Maxfield
Comment 3 2021-09-30 17:37:09 PDT
Created attachment 439803 [details] Patch
EWS Watchlist
Comment 4 2021-09-30 17:38:07 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Myles C. Maxfield
Comment 5 2021-10-01 16:21:13 PDT
Created attachment 439928 [details] Patch
Myles C. Maxfield
Comment 6 2021-10-04 23:11:24 PDT
Created attachment 440162 [details] Patch for committing
EWS
Comment 7 2021-10-05 00:04:23 PDT
Committed r283539 (242504@main): <https://commits.webkit.org/242504@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440162 [details].
Note You need to log in before you can comment on or make changes to this bug.