| Summary: | [CSS Cascade Layers] Add fonts and keyframes in cascade layer order | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 220779 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2021-09-29 05:27:28 PDT
Created attachment 439598 [details]
Patch
Created attachment 439599 [details]
Patch
Comment on attachment 439599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439599&action=review > Source/WebCore/style/RuleSet.cpp:349 > + if (is<StyleRuleFontFace>(*rule) || is<StyleRuleFontPaletteValues>(*rule) || is<StyleRuleKeyframes>(*rule)) { Would be nice to have a way to collectively refer to these. Are they just all the kinds of @ rules we know about? What happens when we add new ones? > Would be nice to have a way to collectively refer to these. Are they just
> all the kinds of @ rules we know about? What happens when we add new ones?
Yeah, there is definitely room for cleanups and clarifications here.
Committed r283216 (242258@main): <https://commits.webkit.org/242258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439599 [details]. |