Bug 230931

Summary:

Display return values in nicer way in the jsc REPL and add a prettyPrint function

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, tsavell, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=231095

Bug Depends on:

231116

Bug Blocks:

Attachments:

Description	Flags
Patch	tzagallo: review+
patch	tzagallo: review+
patch for landing	none
patch	none

Saam Barati

Reported 2021-09-28 19:12:55 PDT

print strings with quotes around them, and arrays with brackets. Currently, print("[1]") looks like print("1") looks like print(1), which is not a great user experience.

Attachments
Patch (5.06 KB, patch) 2021-09-28 19:24 PDT, Saam Barati	tzagallo: review+	Details Formatted Diff Diff
patch (9.07 KB, patch) 2021-09-29 10:23 PDT, Saam Barati	tzagallo: review+	Details Formatted Diff Diff
patch for landing (10.23 KB, patch) 2021-09-29 13:50 PDT, Saam Barati	no flags	Details Formatted Diff Diff
patch (7.39 KB, patch) 2021-10-04 13:21 PDT, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2021-09-28 19:24:03 PDT

Created attachment 439555 [details] Patch

Saam Barati

Comment 2 2021-09-28 19:24:45 PDT

(In reply to Saam Barati from comment #0) > print strings with quotes around them, and arrays with brackets. > > Currently, print("[1]") looks like print("1") looks like print(1), which is > not a great user experience. I meant to say print([1]) for the first example.

Tadeu Zagallo

Comment 3 2021-09-28 19:26:54 PDT

Comment on attachment 439555 [details] Patch r=me

Saam Barati

Comment 4 2021-09-29 10:23:37 PDT

Created attachment 439621 [details] patch

Tadeu Zagallo

Comment 5 2021-09-29 10:25:14 PDT

Comment on attachment 439621 [details] patch r=me

Saam Barati

Comment 6 2021-09-29 13:50:01 PDT

Created attachment 439651 [details] patch for landing