Bug 230919

Summary: Add telemetry to the Networking process sandbox
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2021-09-28 14:49:09 PDT
Add telemetry to the Networking process sandbox on iOS and macOS.
Attachments
Patch (33.07 KB, patch)
2021-09-28 14:51 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (33.10 KB, patch)
2021-09-28 14:55 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (32.27 KB, patch)
2021-09-29 10:08 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-28 14:49:37 PDT
<rdar://problem/83641392>
Per Arne Vollan
Comment 2 2021-09-28 14:51:39 PDT
Created attachment 439524 [details] Patch
Per Arne Vollan
Comment 3 2021-09-28 14:55:40 PDT
Created attachment 439526 [details] Patch
Brent Fulgham
Comment 4 2021-09-29 09:56:46 PDT
Comment on attachment 439526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439526&action=review It looks like you have a bad merge in this patch. Could you please rebase it? > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55 > +(allow file-map-executable (with telemetry) Did you mean to do telemetry for the Private Frameworks paths? Or just everything else? > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415 > +<<<<<<< .mine Uh oh! Bad merge!
Per Arne Vollan
Comment 5 2021-09-29 10:07:18 PDT
(In reply to Brent Fulgham from comment #4) > Comment on attachment 439526 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=439526&action=review > > It looks like you have a bad merge in this patch. Could you please rebase it? > > > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55 > > +(allow file-map-executable (with telemetry) > > Did you mean to do telemetry for the Private Frameworks paths? Or just > everything else? > The intention was to add telemetry for all paths. Perhaps this was done incorrectly? > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415 > > +<<<<<<< .mine > > Uh oh! Bad merge! Ah, will fix :) Thanks for reviewing!
Per Arne Vollan
Comment 6 2021-09-29 10:08:17 PDT
Created attachment 439619 [details] Patch
Brent Fulgham
Comment 7 2021-09-29 10:18:11 PDT
Comment on attachment 439619 [details] Patch r=me
Per Arne Vollan
Comment 8 2021-09-29 12:37:35 PDT
Comment on attachment 439619 [details] Patch Thanks for reviewing!
EWS
Comment 9 2021-09-29 13:07:03 PDT
Committed r283253 (242282@main): <https://commits.webkit.org/242282@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439619 [details].
Note You need to log in before you can comment on or make changes to this bug.