Bug 230919

Summary: Add telemetry to the Networking process sandbox
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2021-09-28 14:49:09 PDT 
Add telemetry to the Networking process sandbox on iOS and macOS.
Comment 1 Radar WebKit Bug Importer 2021-09-28 14:49:37 PDT 
<rdar://problem/83641392>
Comment 2 Per Arne Vollan 2021-09-28 14:51:39 PDT 
Created attachment 439524 [details]
Patch
Comment 3 Per Arne Vollan 2021-09-28 14:55:40 PDT 
Created attachment 439526 [details]
Patch
Comment 4 Brent Fulgham 2021-09-29 09:56:46 PDT 
Comment on attachment 439526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439526&action=review

It looks like you have a bad merge in this patch. Could you please rebase it?

> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55
> +(allow file-map-executable (with telemetry)

Did you mean to do telemetry for the Private Frameworks paths? Or just everything else?

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415
> +<<<<<<< .mine

Uh oh! Bad merge!
Comment 5 Per Arne Vollan 2021-09-29 10:07:18 PDT 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 439526 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439526&action=review
> 
> It looks like you have a bad merge in this patch. Could you please rebase it?
> 
> > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:55
> > +(allow file-map-executable (with telemetry)
> 
> Did you mean to do telemetry for the Private Frameworks paths? Or just
> everything else?
> 

The intention was to add telemetry for all paths. Perhaps this was done incorrectly?

> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:415
> > +<<<<<<< .mine
> 
> Uh oh! Bad merge!

Ah, will fix :)

Thanks for reviewing!
Comment 6 Per Arne Vollan 2021-09-29 10:08:17 PDT 
Created attachment 439619 [details]
Patch
Comment 7 Brent Fulgham 2021-09-29 10:18:11 PDT 
Comment on attachment 439619 [details]
Patch

r=me
Comment 8 Per Arne Vollan 2021-09-29 12:37:35 PDT 
Comment on attachment 439619 [details]
Patch

Thanks for reviewing!
Comment 9 EWS 2021-09-29 13:07:03 PDT 
Committed r283253 (242282@main): <https://commits.webkit.org/242282@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439619 [details].