Bug 23087

Summary: REGRESSION(r39566): Windows build fails due to undeclared FormState class.
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Correct build error none

Brent Fulgham
Reported 2009-01-02 23:04:48 PST
The recent removal of the FormState.h header include from FrameLoader.h causes numerous Windows build errors. This is because MSVC is very finicky about declarations for smart pointers with forward class declarations. It generally wants access to the entire class declaration before it will allow a compile.
Attachments
Correct build error (1.18 KB, patch)
2009-01-02 23:11 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2009-01-02 23:11:56 PST
Created attachment 26389 [details] Correct build error
Mark Rowe (bdash)
Comment 2 2009-01-03 00:28:02 PST
Steve landed an identical change in r39573.
Note You need to log in before you can comment on or make changes to this bug.