Bug 230788 – Negative integers in @font-palette-values are invalid

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Negative integers in @font-palette-values are invalid

[Myles C. Maxfield]

Created attachment 439246 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/83528806>

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Myles C. Maxfield]

Created attachment 439252 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 439252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439252&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:4853
> +    return consumeInteger(range, 0);

I should change the parsed types to be unsigned, too.

[Myles C. Maxfield]

Created attachment 439277 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 439277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439277&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:468
> +            auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberSInt64Type, &index));

Nope

[Myles C. Maxfield]

Created attachment 439397 [details]
Patch

[Myles C. Maxfield]

Created attachment 439414 [details]
Patch

[Myles C. Maxfield]

Created attachment 439438 [details]
Patch

[Myles C. Maxfield]

Committed r283188 (242236@main): <https://commits.webkit.org/242236@main>

[Darin Adler]

Comment on attachment 439438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439438&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:456
>          auto light = kCTFontPaletteLight;
> -        auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberSInt64Type, &light));
> +        auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberCFIndexType, &light));

I am perhaps the biggest fan of "auto" in the entire WebKit project, but here is a place where it’s just not appropriate. Needs to be:

    CFIndex light = kCTFontPaletteLight;

[Myles C. Maxfield]

Committed r283197 (242244@main): <https://commits.webkit.org/242244@main>

[Myles C. Maxfield]

Committed r283540 (242505@main): <https://commits.webkit.org/242505@main>