Bug 230732

Summary:

Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsController

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Scrolling

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Simon Fraser (smfr) 2021-09-23 17:21:22 PDT

Move ScrollSnapAnimatorState's ScrollAnimationMomentum into ScrollingEffectsController

Comment 1 Simon Fraser (smfr) 2021-09-23 17:23:50 PDT

Created attachment 439109 [details]
Patch

Comment 2 Wenson Hsieh 2021-09-23 17:28:54 PDT

Comment on attachment 439109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439109&action=review

> Source/WebCore/platform/ScrollingEffectsController.cpp:145
> +        m_currentAnimation = WTF::makeUnique<ScrollAnimationMomentum>(*this);

Nit - you can omit this `WTF::`

Comment 3 Simon Fraser (smfr) 2021-09-23 22:08:04 PDT

https://trac.webkit.org/changeset/283026/webkit

Comment 4 Radar WebKit Bug Importer 2021-09-23 22:09:19 PDT

<rdar://problem/83480219>