Bug 230726

Summary: [PlayStation] Pass logging channel parameter to WebProcess from environment variable
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: WebKit Misc.Assignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: Basuke.Suzuki, Hironori.Fujii, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
ews-feeder: commit-queue-
PATCH
simon.fraser: review+
PATCH
Hironori.Fujii: commit-queue-
PATCH none

Description Basuke Suzuki 2021-09-23 15:31:03 PDT 
Cocoa port does this in it's platform initialization. It is no drawback when enabling this to all ports. Fields in parameters are already defined. Just not used in other ports than Cocoa.
Comment 1 Basuke Suzuki 2021-09-23 15:32:23 PDT 
This implementation: Source\WebKit\WebProcess\cocoa\WebProcessCocoa.mm

> #if !LOG_DISABLED || !RELEASE_LOG_DISABLED
>     WebCore::initializeLogChannelsIfNecessary(parameters.webCoreLoggingChannels);
>     WebKit::initializeLogChannelsIfNecessary(parameters.webKitLoggingChannels);
> #endif
Comment 2 Radar WebKit Bug Importer 2021-09-30 15:32:17 PDT 
<rdar://problem/83740947>
Comment 3 Basuke Suzuki 2021-09-30 19:54:04 PDT 
Created attachment 439813 [details]
PATCH
Comment 4 Basuke Suzuki 2021-09-30 21:05:50 PDT 
Created attachment 439818 [details]
PATCH
Comment 5 Simon Fraser (smfr) 2021-09-30 21:37:33 PDT 
Comment on attachment 439818 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=439818&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:-400
> -    // Match the QoS of the UIProcess and the scrolling thread but use a slightly lower priority.

This seems like a useful comment. Why delete it?
Comment 6 Basuke Suzuki 2021-09-30 22:19:19 PDT 
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 439818 [details]
> PATCH
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439818&action=review
> 
> > Source/WebKit/WebProcess/WebProcess.cpp:-400
> > -    // Match the QoS of the UIProcess and the scrolling thread but use a slightly lower priority.
> 
> This seems like a useful comment. Why delete it?

Ah, sorry that was accident. I'll revert the comment. Thanks.
Comment 7 Basuke Suzuki 2021-09-30 22:20:54 PDT 
Created attachment 439821 [details]
PATCH
Comment 8 Fujii Hironori 2021-09-30 22:41:48 PDT 
I think this change will break WebProcess logging of GTK, WPE and WinCairo because they don't set wtfLoggingChannels.
Comment 9 Basuke Suzuki 2021-09-30 23:17:12 PDT 
(In reply to Fujii Hironori from comment #8)
> I think this change will break WebProcess logging of GTK, WPE and WinCairo
> because they don't set wtfLoggingChannels.

Oh, really? Hmm. It's safe to do this in PlayStation port, not moving it to shared. Thanks.
Comment 10 Basuke Suzuki 2021-10-01 16:00:53 PDT 
Created attachment 439923 [details]
PATCH
Comment 11 EWS 2021-10-03 14:02:27 PDT 
Committed r283478 (242451@main): <https://commits.webkit.org/242451@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439923 [details].