Bug 230726

Summary: [PlayStation] Pass logging channel parameter to WebProcess from environment variable
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebKit Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, fujii.hironori, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
ews-feeder: commit-queue-
PATCH
simon.fraser: review+
PATCH
fujii.hironori: commit-queue-
PATCH none

Basuke Suzuki
Reported 2021-09-23 15:31:03 PDT
Cocoa port does this in it's platform initialization. It is no drawback when enabling this to all ports. Fields in parameters are already defined. Just not used in other ports than Cocoa.
Attachments
PATCH (3.91 KB, patch)
2021-09-30 19:54 PDT, Basuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
PATCH (4.94 KB, patch)
2021-09-30 21:05 PDT, Basuke Suzuki 		simon.fraser: review+
DetailsFormatted DiffDiff
PATCH (4.80 KB, patch)
2021-09-30 22:20 PDT, Basuke Suzuki 		fujii.hironori: commit-queue-
DetailsFormatted DiffDiff
PATCH (3.37 KB, patch)
2021-10-01 16:00 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2021-09-23 15:32:23 PDT
This implementation: Source\WebKit\WebProcess\cocoa\WebProcessCocoa.mm > #if !LOG_DISABLED || !RELEASE_LOG_DISABLED > WebCore::initializeLogChannelsIfNecessary(parameters.webCoreLoggingChannels); > WebKit::initializeLogChannelsIfNecessary(parameters.webKitLoggingChannels); > #endif
Radar WebKit Bug Importer
Comment 2 2021-09-30 15:32:17 PDT
<rdar://problem/83740947>
Basuke Suzuki
Comment 3 2021-09-30 19:54:04 PDT
Created attachment 439813 [details] PATCH
Basuke Suzuki
Comment 4 2021-09-30 21:05:50 PDT
Created attachment 439818 [details] PATCH
Simon Fraser (smfr)
Comment 5 2021-09-30 21:37:33 PDT
Comment on attachment 439818 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=439818&action=review > Source/WebKit/WebProcess/WebProcess.cpp:-400 > - // Match the QoS of the UIProcess and the scrolling thread but use a slightly lower priority. This seems like a useful comment. Why delete it?
Basuke Suzuki
Comment 6 2021-09-30 22:19:19 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 439818 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=439818&action=review > > > Source/WebKit/WebProcess/WebProcess.cpp:-400 > > - // Match the QoS of the UIProcess and the scrolling thread but use a slightly lower priority. > > This seems like a useful comment. Why delete it? Ah, sorry that was accident. I'll revert the comment. Thanks.
Basuke Suzuki
Comment 7 2021-09-30 22:20:54 PDT
Created attachment 439821 [details] PATCH
Fujii Hironori
Comment 8 2021-09-30 22:41:48 PDT
I think this change will break WebProcess logging of GTK, WPE and WinCairo because they don't set wtfLoggingChannels.
Basuke Suzuki
Comment 9 2021-09-30 23:17:12 PDT
(In reply to Fujii Hironori from comment #8) > I think this change will break WebProcess logging of GTK, WPE and WinCairo > because they don't set wtfLoggingChannels. Oh, really? Hmm. It's safe to do this in PlayStation port, not moving it to shared. Thanks.
Basuke Suzuki
Comment 10 2021-10-01 16:00:53 PDT
Created attachment 439923 [details] PATCH
EWS
Comment 11 2021-10-03 14:02:27 PDT
Committed r283478 (242451@main): <https://commits.webkit.org/242451@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439923 [details].
Note You need to log in before you can comment on or make changes to this bug.